chore(deps): dependency housekeeping #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiintbrisson
commented
Aug 17, 2023
| @@ -1,6 +1,6 @@ | |||
| //! This module contains implementations of `Dummy` trait | |||
|
|
|||
| #[cfg(feature = "bigdecimal")] | |||
| #[cfg(feature = "bigdecimal-rs")] | |||
There was a problem hiding this comment.
This allows for the use of bigdecimal-rs directly without needing to enable rust_decimal as well.
saiintbrisson
commented
Aug 17, 2023
There was a problem hiding this comment.
Solved clippy errors.
saiintbrisson
commented
Aug 17, 2023
There was a problem hiding this comment.
I've added the Cargo.lock file to prevent possible dependency mismatches between dev environments, but this is not required.
|
Hi @cksac! Sorry for the inconvenience, but could you please publish the new versions for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change performs some housekeeping activities such as disabling unneeded dependency features.
The renaming from
bigdecimal_rstobigdecimal-rswas done to comply with the bigdecimal repository name (bigdecimal-rs), this shouldn't be breaking as it does not have any impact since the feature flag for the impl was wrong and requiredbigdecimalinstead ofbigdecimal_rs.I also believe the
bigdecimalfeature flag which enables bothbigdecimalandrust_decimalshould be deprecated in favor of enabling the specific feature flags manually, but this would be a breaking change and requires a new major version.Important
Bumped
faketo 2.8 anddummyto 0.6.