Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image URL #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Image URL #27

wants to merge 1 commit into from

Conversation

MrRobb
Copy link

@MrRobb MrRobb commented Oct 4, 2019

Feature: Add Image faker (it's not https://www.lorempixel.com but related to #25).

@cksac
Copy link
Owner

cksac commented Oct 5, 2019

Thanks for the PR. As #25 's discussion, we would like to use the image provider as namespace and I am not sure is it necessary to have locale for image faker. I would suggest use something like

pub enum Picsum {
    Default,
    WithSize(u16, u16),
}

or

pub struct Picsum {
   height: u16,
   width: u16,
   blur: u8,
   is_grayscale: bool,
}

then implement Dummy<Picsum> for String without locale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants