Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Accessibility Checker behaviour when no issues are detected #5

Closed
mlewand opened this issue Oct 1, 2014 · 1 comment
Closed
Assignees

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 1, 2014

We should unify behavior of Accessibility Checker when no a11y issues are detected.

Cases

Checking empty document

  1. Open any sample with Accessibility Checker. (i.e. plugins/a11ychecker/dev/sample.html)
  2. Clear the CKEditor contents, using "New Page" button.
  3. Execute Accessibility Checker, eg. by clicking a its toolbar button.

Fixing the last problematic element

  1. Open any sample with Accessibility Checker. (i.e. plugins/a11ychecker/dev/sample.html)
  2. Set the CKEditor contents using "Source" button to:
<p>This is a sample date: 12-04-12.</p>
  1. Execute Accessibility Checker.
  2. Navigate to the issue, eg CTRL + E.
  3. Apply a Quick Fix.

Expected result:
For the time being alert with an appropriate message will be sufficient.

@mlewand mlewand self-assigned this Oct 3, 2014
@mlewand
Copy link
Contributor Author

mlewand commented Oct 3, 2014

Actually we might thing about firing an event in Controller class in case of positive content check.

The event would be like validated or contentValidated.

But the same functionallity can be achieved by using Controller checked event, simply by checking IssueList size (count). This is quite logical and easy to figure out, so I'll not implement it for the time being just to keep it simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant