Merge pull request #53 from cksource/t/47

Other: Shortened hashes to 7-char version in the `save-hashes` command. Closes #47.
cksource · Jul 4, 2017 · 73990c8 · 73990c8
2 parents 5751eb7 + 335b392
commit 73990c8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/commands/savehashes.js b/lib/commands/savehashes.js
@@ -25,7 +25,7 @@ module.exports = {
 
 					const commandResponse = {
 						packageName: data.packageName,
-						commit: commitHash
+						commit: commitHash.slice( 0, 7 ) // Short version of the commit hash.
 					};
 
 					log.info( `Commit: "${ commitHash }".` );

diff --git a/tests/commands/savehashes.js b/tests/commands/savehashes.js
@@ -74,7 +74,7 @@ describe( 'commands/savehashes', () => {
 		it( 'resolves promise with last commit id', () => {
 			const execCommandResponse = {
 				logs: {
-					info: [ '584f34152d782cc2f26453e10b93c4a16ef01925' ]
+					info: [ '584f341' ]
 				}
 			};
 
@@ -90,10 +90,10 @@ describe( 'commands/savehashes', () => {
 
 					expect( commandResponse.response ).to.deep.equal( {
 						packageName: data.packageName,
-						commit: '584f34152d782cc2f26453e10b93c4a16ef01925'
+						commit: '584f341'
 					} );
 
-					expect( commandResponse.logs.info[ 0 ] ).to.equal( 'Commit: "584f34152d782cc2f26453e10b93c4a16ef01925".' );
+					expect( commandResponse.logs.info[ 0 ] ).to.equal( 'Commit: "584f341".' );
 				} );
 		} );
 	} );
@@ -108,11 +108,11 @@ describe( 'commands/savehashes', () => {
 
 			commandResponses.add( {
 				packageName: 'test-package',
-				commit: '584f34152d782cc2f26453e10b93c4a16ef01925'
+				commit: '584f341'
 			} );
 			commandResponses.add( {
 				packageName: 'package-test',
-				commit: '52910fe61a4c39b01e35462f2cc287d25143f485'
+				commit: '52910fe'
 			} );
 
 			saveHashesCommand.afterExecute( processedPackages, commandResponses );
@@ -131,8 +131,8 @@ describe( 'commands/savehashes', () => {
 			json = updateFunction( json );
 
 			expect( json.dependencies ).to.deep.equal( {
-				'test-package': 'organization/test-package#584f34152d782cc2f26453e10b93c4a16ef01925',
-				'package-test': 'organization/package-test#52910fe61a4c39b01e35462f2cc287d25143f485',
+				'test-package': 'organization/test-package#584f341',
+				'package-test': 'organization/package-test#52910fe',
 				'other-package': 'organization/other-package'
 			} );
 		} );