Merge pull request #90 from cksource/t/86

Fix: Mgit should end with proper exit code if some command failed. Closes #86.
cksource · Nov 19, 2018 · b7b878b · b7b878b
2 parents 4fdc134 + ed6a88f
commit b7b878b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -46,6 +46,7 @@ module.exports = function( args, options ) {
 
 	const processedPackages = new Set();
 	const commandResponses = new Set();
+	const packagesWithError = new Set();
 	const packageNames = getPackageNames( options );
 
 	let allPackagesNumber = packageNames.length;
@@ -97,6 +98,10 @@ module.exports = function( args, options ) {
 				}
 
 				if ( returnedData.logs ) {
+					if ( returnedData.logs.error.length ) {
+						packagesWithError.add( packageName );
+					}
+
 					logDisplay( packageName, returnedData.logs, {
 						current: donePackagesNumber,
 						all: allPackagesNumber,
@@ -125,6 +130,14 @@ module.exports = function( args, options ) {
 				const endTime = process.hrtime( startTime );
 
 				console.log( chalk.cyan( `Execution time: ${ endTime[ 0 ] }s${ endTime[ 1 ].toString().substring( 0, 3 ) }ms.` ) );
+
+				if ( packagesWithError.size ) {
+					const repositoryForm = packagesWithError.size === 1 ? 'repository' : 'repositories';
+					const message = `\n❗❗❗ The command failed to execute in ${ packagesWithError.size } ${ repositoryForm }.\n`;
+
+					console.log( chalk.red( message ) );
+					process.exit( 1 );
+				}
 			} );
 	}
 };
diff --git a/lib/utils/displaylog.js b/lib/utils/displaylog.js
@@ -38,8 +38,6 @@ module.exports = function displayLog( packageName, logs, options ) {
 	}
 
 	if ( errorLogs ) {
-		process.exitCode = 1;
-
 		console.log( chalk.red( errorLogs ) );
 	}