Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #86

Closed
pomek opened this issue Oct 15, 2018 · 4 comments
Closed

Improve error handling #86

pomek opened this issue Oct 15, 2018 · 4 comments
Labels
resolution:solved type:enhancement

Comments

@pomek
Copy link
Member

pomek commented Oct 15, 2018

ckeditor/ckeditor5#1294 (comment)

If some command failed, mgit should change exit code and display which repo ends with an error. At this moment you can miss that something went wrong because mgit displays a very long.
@Reinmar
Copy link
Member

Reinmar commented Oct 15, 2018

and display which repo ends with an error

It'd be enough if it wrote a big red "The command failed to execute in N repositories." at the end.

@Reinmar
Copy link
Member

Reinmar commented Oct 24, 2018

The same here:

image

@Reinmar
Copy link
Member

Reinmar commented Oct 24, 2018

If I had a smaller screen I wouldn't notice that.

@ma2ciek
Copy link
Contributor

ma2ciek commented Nov 15, 2018

Big 👍 for this ticket.

Now, mgit actually can't be a part of some task because we don't know when it fails.

@pomek pomek mentioned this issue Nov 16, 2018
Merged
Reinmar added a commit that referenced this issue Nov 19, 2018
@Reinmar
Merge pull request #90 from cksource/t/86
b7b878b 
Fix: Mgit should end with proper exit code if some command failed. Closes #86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution:solved type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Reinmar @pomek @ma2ciek @Mgsy