Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check for remote hangups is too strict #92

Closed
Reinmar opened this issue Nov 30, 2018 · 0 comments
Closed

The check for remote hangups is too strict #92

Reinmar opened this issue Nov 30, 2018 · 0 comments

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 30, 2018

Apparently, on some git versions or OS locales, this error is printed out a bit differently:

 #  @ckeditor/ckeditor5-upload                                           39/39 (100%)
Cloning into '/Users/pjasiun/workspace/ckeditor5/packages/ckeditor5-upload'...
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (5/5), done.
packet_write_wait: Connection to 192.30.253.113 port 22: Broken pipe
fatal: the remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

The current check expects fatal: The remote... and that does not match.

I think that this check is in general too complicated. /fatal: the remote end hung up unexpectedly/i should be enough. After all, nothing bad should happen if we have false positive anyway.

This was referenced Dec 3, 2018
Reinmar added a commit that referenced this issue Dec 5, 2018
Fix: Simplified a check for "remote end hung up" error during the `bootstrap` command. Closes #92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants