Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified the error check #93

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Simplified the error check #93

merged 2 commits into from
Dec 5, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Dec 3, 2018

Suggested merge commit message (convention)

Fix: Simplified a check for "remote end hung up" error during the bootstrap command. Closes #92.

@coveralls
Copy link

coveralls commented Dec 3, 2018

Pull Request Test Coverage Report for Build 263

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 98.964%

Totals Coverage Status
Change from base Build 256: -0.01%
Covered Lines: 300
Relevant Lines: 302

💛 - Coveralls

Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a test.

@pomek
Copy link
Member Author

pomek commented Dec 3, 2018

Missing a test.

I did it on purpose because this test has no value. If the previous one (that uses capital letters) passes, next one with small letters will pass as well. And on the occasion, we increased tests execution time by 5 secs. Missing test has been added.

@Reinmar
Copy link
Member

Reinmar commented Dec 3, 2018

If the previous one (that uses capital letters) passes, next one with small letters will pass as well.

Somehow, the bug was there. So the previous implementation was missing this case. Therefore, it deserves a test that fails if we somehow revert/break this in the future again.

@Reinmar
Copy link
Member

Reinmar commented Dec 3, 2018

cc @pjasiun could you retest?

@pjasiun
Copy link

pjasiun commented Dec 4, 2018

Works 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants