Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mgit should end with proper exit code if some command failed #90

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Mgit should end with proper exit code if some command failed #90

merged 3 commits into from
Nov 19, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Nov 16, 2018

Suggested merge commit message (convention)

Fix: Mgit should end with proper exit code if some command failed. Closes #86.

@pomek pomek requested a review from ma2ciek November 16, 2018 12:39
@coveralls
Copy link

coveralls commented Nov 16, 2018 •
edited

Pull Request Test Coverage Report for Build 232

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.898%
Totals Coverage Status
Change from base Build 214: 0.0%
Covered Lines: 285
Relevant Lines: 287
💛 - Coveralls

@Reinmar
Copy link
Member

Reinmar commented Nov 19, 2018

image

This should be red and loud and, in general, much more visible. Some emojis would not hurt.

@Reinmar
Copy link
Member

Reinmar commented Nov 19, 2018

Also, it could be "1 repository".

@pomek
Copy link
Member Author

pomek commented Nov 19, 2018

Should be good now.

@Reinmar Reinmar merged commit b7b878b into master Nov 19, 2018
@Reinmar Reinmar deleted the t/86 branch November 19, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ma2ciek ma2ciek Awaiting requested review from ma2ciek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pomek @coveralls @Reinmar