Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced the "overrideDirectoryNames" option in a config #98

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Conversation

pomek
Copy link
Member

@pomek pomek commented Jan 16, 2019

Suggested merge commit message (convention)

Feature: Introduced an option (overrideDirectoryNames) that allows modifying a directory where a package would be cloned. Closes #72.

@pomek pomek requested a review from Reinmar January 16, 2019 13:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 289

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/utils/getoptions.js 1 2 50.0%
Totals Coverage Status
Change from base Build 284: -0.3%
Covered Lines: 490
Relevant Lines: 491

💛 - Coveralls

@pomek
Copy link
Member Author

pomek commented Mar 6, 2019

Ping, @Reinmar or @ma2ciek.

lib/utils/getoptions.js Outdated Show resolved Hide resolved
@pomek
Copy link
Member Author

pomek commented Jun 6, 2019

Could you show how I can easily change existing mgit.json to test it?

Modify your mgit.json according to #72. To be honest, the entire test case was described in the ticket.

@ma2ciek
Copy link
Contributor

ma2ciek commented Jun 6, 2019

All works fine!

Despite testing, but it's a thing for the future (as right now the test env is inside the @ckeditor/ckeditor5-cloud-services-core package).

@ma2ciek ma2ciek merged commit 55026b4 into master Jun 6, 2019
@ma2ciek ma2ciek deleted the t/72 branch June 6, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding package names in packages/*
3 participants