Merge pull request #78 from cksource/t/74

Fix: Whitespaces in a CWD should not break the `bootstrap` command. Closes #74.
cksource · May 4, 2018 · 3a5eaac · 3a5eaac
2 parents 7c2a2ee + be9485d
commit 3a5eaac
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/commands/bootstrap.js b/lib/commands/bootstrap.js
@@ -32,8 +32,8 @@ module.exports = {
 			promise = Promise.resolve();
 		} else {
 			const command = [
-				`git clone --progress ${ data.repository.url } ${ destinationPath }`,
-				`cd ${ destinationPath }`,
+				`git clone --progress "${ data.repository.url }" "${ destinationPath }"`,
+				`cd "${ destinationPath }"`,
 				`git checkout --quiet ${ data.repository.branch }`
 			].join( ' && ' );
 

diff --git a/tests/commands/bootstrap.js b/tests/commands/bootstrap.js
@@ -88,9 +88,9 @@ describe( 'commands/bootstrap', () => {
 
 					// Clone the repository.
 					expect( cloneCommand[ 0 ] )
-						.to.equal( 'git clone --progress git@github.com/organization/test-package.git packages/test-package' );
+						.to.equal( 'git clone --progress "git@github.com/organization/test-package.git" "packages/test-package"' );
 					// Change the directory to cloned package.
-					expect( cloneCommand[ 1 ] ).to.equal( 'cd packages/test-package' );
+					expect( cloneCommand[ 1 ] ).to.equal( 'cd "packages/test-package"' );
 					// And check out to proper branch.
 					expect( cloneCommand[ 2 ] ).to.equal( 'git checkout --quiet master' );