Possible bug for logical right shift #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shifting a signed integer n, where n<0, by 31 bits the current return value would result in 0.
This happens because rightShift(int n, int b) is set to return 0 whenever b is greater than 30.
Actually the shift should result in 1, since we see the number as a normal bit sequence when logically shifting, as far as I can conclude from the implementation.
Probably this is not that a big problem, since I did not see this case happen in selfie.c. But it should be considered, for completeness.
If this holds, the same goes for leftShift(int n, int b). When shifting an odd number by 31 bits logically to the left, the result should be INT_MIN, not 0.