Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baikal does not work anymore in latest containers #5

Closed
therealprof opened this issue Dec 9, 2017 · 3 comments
Closed

Baikal does not work anymore in latest containers #5

therealprof opened this issue Dec 9, 2017 · 3 comments
Assignees
Labels

Comments

@therealprof
Copy link

PHP was obviously automatically upgraded to 7.2 in latest builds but Baikal is not compatible with that version anymore due to the use of deprecated functions.

Pinning the used php container to 7.0 for instance works until the Baikal project decides to address sabre-io/Baikal#711 . I'd be happy to submit a PR for this but it's probably faster to simply add 3 characters to the Dockerfile. ;)

@baukita
Copy link

baukita commented Mar 3, 2018

Would you please explain what 3 characters I should add then please? I'm trying to set this up but facing issues due to php version

@therealprof
Copy link
Author

@Bajista58 Open the Dockerfile and change the beginning of the file to:

# Set the base image
FROM php:7.0-apache

ckulka added a commit that referenced this issue Apr 18, 2018
@ckulka ckulka self-assigned this Apr 18, 2018
@ckulka ckulka added the bug label Apr 18, 2018
@ckulka
Copy link
Owner

ckulka commented Apr 18, 2018

@therealprof @Bajista58 only saw it now, sorry ... had notifications turned off.

Thanks for the suggested fix, I changed the base image to php:7.0-apache and it runs smooth again. So far only latest and 0.4.6 tags are fixed, older versions will be updated if anyone actually needs them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants