Added/Updated some test cases

ckyycc · Mar 2, 2019 · 2592d01 · 2592d01
1 parent 263f480
commit 2592d01
Show file tree

Hide file tree

Showing 3 changed files with 69 additions and 5 deletions.
diff --git a/test/Pool.js b/test/Pool.js
@@ -304,7 +304,7 @@ describe('Pool', function () {
   describe('#addResourceToAvailable', function () {
     let resource;
     beforeEach(() => {
-      resource = new Resource();
+      resource = new Resource(undefined);
     });
     it('should add the resource to available resource list', function () {
       pool.addResourceToAvailable(resource).catch(() => '');
@@ -342,7 +342,7 @@ describe('Pool', function () {
   describe('#replacePlaceHolderWithConnectionFromAll', function () {
     let resource;
     beforeEach(() => {
-      resource = new Resource();
+      resource = new Resource(undefined);
     });
     it('should replace the placeholder with the provided resource from the pool', function () {
       const placeHolder = Symbol('PlaceHolder4Creation');
@@ -354,14 +354,22 @@ describe('Pool', function () {
       });
     });
 
-    it('#should not call _notifyAllOperators once', function () {
+    it('#should call _notifyAllOperators once', function () {
       const placeHolder = Symbol('PlaceHolder4Creation');
       pool['_allResources'].push(placeHolder);
       spy = sinon.spy(pool, '_notifyAllOperators');
       pool.replacePlaceHolderWithConnectionFromAll(placeHolder, resource).catch(() => '');
       sinon.assert.calledOnce(spy);
     });
 
+    it('#should not call _notifyAllOperators if resource is a Symbol as well', function () {
+      const placeHolder = Symbol('PlaceHolder4Creation');
+      pool['_allResources'].push(placeHolder);
+      spy = sinon.spy(pool, '_notifyAllOperators');
+      pool.replacePlaceHolderWithConnectionFromAll(placeHolder, Symbol('PlaceHolder4Creation')).catch(() => '');
+      sinon.assert.notCalled(spy);
+    });
+
     it('#should return rejected promise if the placeHolder cannot be matched', function () {
       const placeHolder = Symbol('PlaceHolder4Creation');
       return pool.replacePlaceHolderWithConnectionFromAll(placeHolder, resource).catch(() => {
@@ -462,6 +470,27 @@ describe('Pool', function () {
       should(pool.isPoolInitialized()).equals(pool['_initializeFlag']);
     });
   });
+
+  // describe('#_checkConnectionIdleTimeout', function () {
+  //   const time = 500;
+  //   let clock;
+  //   before(function() {
+  //     clock = sinon.useFakeTimers();
+  //   });
+  //   after(function() {
+  //     clock.restore();
+  //   });
+  //   it('#shoud emit error if _notifyAllOperators failed', function () {
+  //     const errorMsg = 'Error_NotifyAllOperators';
+  //     stub = Stub.getStubForObjectWithRejectedPromise(pool, '_notifyAllOperators', errorMsg);
+  //     spy = sinon.spy(Utils, 'emitMessage');
+  //     pool['_checkConnectionIdleTimeout'](time);
+  //     clock.tick(500);
+  //     sinon.assert.calledOnce(spy);
+  //     // sinon.assert.calledWith(spy, EventType.ERROR);
+  //   });
+  // });
+
   describe('#_notifyAllOperators', function () {
     let stubList;
     beforeEach(() => {
@@ -478,14 +507,31 @@ describe('Pool', function () {
         should(str).equals(Stub.resolvedMessage);
       });
     });
-    it('#should reject if no taskFound.', function () {
+    // `Something wrong, can not find any worker for task ${task && task.taskType ? task.taskType : 'None'}`
+
+    it('#should reject if no taskFound (task is undefined).', function () {
       const rejectError = 'it was not supposed to succeed.';
       pool['_operators'].forEach((operator) => {
         stubList.push(Stub.getStubForOperatorWithObject(operator, 'work', null));
       });
       return pool['_notifyAllOperators']()
         .then(() => Promise.reject(rejectError))
-        .catch((err) => should.notStrictEqual(err, rejectError));
+        .catch((err) => {
+          should(err.message).equals('Something wrong, can not find any worker for task None');
+        });
+    });
+
+    it('#should reject if no taskFound (task is not undefined).', function () {
+      const rejectError = 'it was not supposed to succeed.';
+      pool['_operators'].forEach((operator) => {
+        stubList.push(Stub.getStubForOperatorWithObject(operator, 'work', null));
+      });
+      const Task = {taskType: 'JUST_FOR_TEST'};
+      return pool['_notifyAllOperators'](Task)
+        .then(() => Promise.reject(rejectError))
+        .catch((err) => {
+          should(err.message).equals('Something wrong, can not find any worker for task JUST_FOR_TEST');
+        });
     });
   });
 });
diff --git a/test/PoolOperator.js b/test/PoolOperator.js
@@ -175,6 +175,16 @@ describe('PoolOperator', function () {
   });
 
   describe('#_checkIdleTimeout', function () {
+    it('#should not touch the resource if it is not timeout', function () {
+      const resource1 = new Resource({});
+      resource1['_lastIdleTime'] = Date.now();
+      operator.pool['_availableResources'].push(resource1);
+      stub1 = Stub.getStubForObjectWithResolvedPromise(operator, 'destroy');
+      stub2 = Stub.getStubForObjectWithResolvedPromise(operator, '_ensureMinPoolResources');
+      return operator['_checkIdleTimeout']().then(() => {
+        sinon.assert.notCalled(stub1);
+      });
+    });
     it('#should try to destroy all (3) the resources from the pool (total is 5) if idle timeout.', function () {
       const timeout = operator.pool.options.idleTimeout + 300000;
 

diff --git a/test/Request.js b/test/Request.js
@@ -158,6 +158,14 @@ describe('Request', function () {
       request['_setTimeout']('AA');
       sinon.assert.calledOnce(spy);
     });
+    it('#should not do anything if delay is not number and state is not in pending', function () {
+      const request = new Request(1);
+      request.promise.catch(() => '');
+      request['_state'] = RequestState.REJECTED;
+      spy = sinon.spy(request, 'reject');
+      request['_setTimeout']('AA');
+      sinon.assert.notCalled(spy);
+    });
     it('#should call reject is delay is less than 0', function () {
       const request = new Request(1);
       request.promise.catch(() => '');