Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not checking the full commit range #168

Closed
marvin-bitterlich opened this issue Oct 29, 2016 · 6 comments
Closed

Not checking the full commit range #168

marvin-bitterlich opened this issue Oct 29, 2016 · 6 comments

Comments

@marvin-bitterlich
Copy link

It seems that cla assistant is missing commits in fairly long prs, like this one f.e.:
ldtteam/minecolonies#238

After more then 250 commits it misses the newest ones and so misses some contributors (only found 4 out of at least 6).

Will it be possible to bump this limit up somehow?

KharitonOff added a commit that referenced this issue Nov 3, 2016
@KharitonOff
Copy link
Contributor

@Kostronor can you click on "Recheck PRs" in CLA assistant please and check wether it is working now

@marvin-bitterlich
Copy link
Author

@KharitonOff I clicked it, waited 2 minutes and clicked it again. So far no update for the pr as it seems.

@KharitonOff
Copy link
Contributor

@Kostronor ok, thank you! I'll keep on searching ...

@marvin-bitterlich
Copy link
Author

@KharitonOff If there is any more Info I can supply please tell!

@KharitonOff
Copy link
Contributor

now it should work with large commit ranges. I was looking for the root cause on the wrong side. The threshold of 250 is set by GitHub...
Now we take all commits pushed to the PR-branch since the date of the PR base commit.

@marvin-bitterlich
Copy link
Author

@KharitonOff I kicked off a new recheck and now 13 contributors are found. That looks like a solid number so I'd say it is done.

Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants