Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA signed but assistant still says not signed #241

Closed
loewenstein opened this issue Jul 11, 2017 · 11 comments
Closed

CLA signed but assistant still says not signed #241

loewenstein opened this issue Jul 11, 2017 · 11 comments

Comments

@loewenstein
Copy link

I have got a PR on my repo SAP-archive/bosh-kubernetes-cpi-release#1

The author has two github users. He committed with one, opened the PR with another. In the cla assistant I only see one of his users. @amitkgupta claims (and sent me a screenshot) that he gets a already signed screen when trying to sign with his second user.

Any idea what could be wrong here?

@matz3
Copy link
Contributor

matz3 commented Jul 12, 2017

It seems that one user is still not signed. See my comment in the PR.

@KharitonOff
Copy link
Contributor

there is no entry with @amitkgupta in the DB. He should Sign out from github and try to sign the CLA. CLA navigates him to the Sign In-page where he should use credentials of @amitkgupta

@loewenstein
Copy link
Author

loewenstein commented Jul 12, 2017

Discussing that with Matthias we might have found the root of the confusion.

I suppose the PR author signed in with the correct user in github, however he was still signed in with his other account with @CLAassistant.

Unfortunately there is no trace of that in the UI and no possibility to re-login other than via @CLAassistant root page. If I am not mistaken he has to login there in order to log himself out.

@loewenstein
Copy link
Author

@KharitonOff no matter if the proposed workaround actually works or not, I would consider the status quo a UX issue that should be properly fixed. Could be done by:

  1. Showing the current user on CLA sign up page
  2. Provide a way to switch user or logout on CLA sign up page

WDYT?

@stale
Copy link

stale bot commented Oct 30, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 30, 2017
@loewenstein
Copy link
Author

@KharitonOff bump

@stale stale bot removed the wontfix label Oct 31, 2017
@KharitonOff
Copy link
Contributor

@loewenstein, will consider your proposal by the next release

@stale
Copy link

stale bot commented Jan 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 29, 2018
@loewenstein
Copy link
Author

loewenstein commented Jan 29, 2018 via email

@stale stale bot removed the wontfix label Jan 29, 2018
@stale
Copy link

stale bot commented Apr 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 29, 2018
@loewenstein
Copy link
Author

@KharitonOff any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants