Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable link repo with a different CLA from its org CLA if exists #251

Closed
MichaelTsengLZ opened this issue Jul 25, 2017 · 5 comments
Closed

Comments

@MichaelTsengLZ
Copy link
Contributor

MichaelTsengLZ commented Jul 25, 2017

As I mentioned earlier in issue #246, Microsoft has a more complex CLA configuration. One scenario is that we may need to override the org CLA with a different CLA. We are planning for the following changes.

  1. We'd like to change the code that tries to get org CLA first and if not exists then get repo CLA. We will flip the order.
  2. Since we allow overridden CLAs, we will delete the repo webhook when its org linked and create webhook when its org is unlinked.
  3. Because exclude repo list of an org is not that easy to maintain. We add a null type CLA only for repos to achieve the same goal. (Leave the exclude repo list as it is for a compatible reason.)

Any guidance?

@KharitonOff
Copy link
Contributor

@MichaelTsengLZ I found one minor issue:
screen shot 2017-09-06 at 14 35 25
this happens if I "relink" the repo/org to use the same gist as shared one and the user signs the shared gist for another repo.

@MichaelTsengLZ
Copy link
Contributor Author

Do you expect to filter out the same contributors and just show the latest signature?

@jeffmcaffer
Copy link

@KharitonOff is this when the user first signed CLA when the gist was NOT shared and then, after relinking as shared, signed again?

@KharitonOff
Copy link
Contributor

@jeffmcaffer exactly.
@MichaelTsengLZ yes, I would prefer to see only the last signature, then it wouldn't show my user as "2 contributers"

@MichaelTsengLZ
Copy link
Contributor Author

@KharitonOff All right, I will send a pull request today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants