Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiencing 502 errors when signing CLA #340

Closed
rojotek opened this issue Jun 15, 2018 · 3 comments
Closed

Experiencing 502 errors when signing CLA #340

rojotek opened this issue Jun 15, 2018 · 3 comments
Labels

Comments

@rojotek
Copy link

rojotek commented Jun 15, 2018

I'm currently testing CLA assistant on a personal repo before considering rolling it out across our organisation.

Unfortunately, people are getting 502 errors after signing the CLA.

They get the expected CLA not signed message, and then when they sign it they end up with a 502.
URL to the linked Repo/Org:
https://github.com/rojotek/swift-run

Steps to reproduce the problem:

  1. Create a PR against the repo
  2. Sign the CLA
  3. get the 502. It will initially look like the CLA wasn't signed to the signer, but really it was

What is the expected result?

Don't get the 502. PR check will pass.
What happens instead?
get the 502 error. It will initially look like the CLA wasn't signed to the signer, but really it was

@KharitonOff
Copy link
Contributor

Thank you very much for reporting this!! 👍

@rojotek
Copy link
Author

rojotek commented Jun 19, 2018

So the cause for me was missing the json metadata with the gist license file. It would be awesome if there was a check for metadata somewhere to help catch this. Maybe in the validations when setting up the license.

@KharitonOff
Copy link
Contributor

I'm glad that you could find the problem and solve it!
The 502 shouldn't happen and there was a bug in the last implementation. Normally you see an error message on the CLA page if JSON format is wrong. A metadata file is optional, that's why we don't validate it (it would be good to have the validation, but there is too little capacity on our side to implement it too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants