Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hook running, but not doing anything #63

Closed
kwquick opened this issue Aug 11, 2015 · 3 comments
Closed

hook running, but not doing anything #63

kwquick opened this issue Aug 11, 2015 · 3 comments

Comments

@kwquick
Copy link

kwquick commented Aug 11, 2015

I setup a test repository (kwquick/test_cla) and it's identified as status green (everything is ok) for cla-assistant, and I see the hook, but a non-confirmed client doesn't see prompts and I don't see any indications in the pull request that they have not confirmed the cla. Can you help identify what is wrong? I can grant you access to this test repo if needed.
@KharitonOff
Copy link
Contributor

Hi Kevin,
the problem here is, that the committer of both pull requests is not a github user. CLA assistant doesn't cover this use case yet.
Definitely there should be at least a notification from the CLA assistant that this committer hasn't sign the CLA. We will probably not provide a possibility to sign a CLA without a github account, but we'll fix the notification logic.
I suppose that if aztsmith changes his/her e-mail to the same one he/she used in the commits then github (and CLA assistant also) will identify him/her as the committer of the pull requests.

@kwquick
Copy link
Author

kwquick commented Aug 12, 2015

Hi Anton,

That was indeed the problem, and when my test committer associated his email with his github account it started working just fine.

I agree that getting signatures from non-github-accounts is probably out of scope, but having a notification of the issue on the pull request would definitely be nice.

Thanks, and I'm enjoying the cla-assistant!

@KharitonOff
Copy link
Contributor

should be solved via 0efa36f

MichaelTsengLZ added a commit to MichaelTsengLZ/cla-assistant that referenced this issue Nov 30, 2017
@MichaelTsengLZ
Bugfix: enlarge the body parser limitation. (cla-assistant#63)
3ad7522 
* Bugfix: enlarge the body parser limitation.

When body parser parse the web hook event payload. It throw the error bellow.

PayloadTooLargeError: request entity too large
    at readStream (/cla-assistant/node_modules/raw-body/index.js:155:17)
    at getRawBody (/cla-assistant/node_modules/raw-body/index.js:108:12)
    at read (/cla-assistant/node_modules/body-parser/lib/read.js:77:3)
    at jsonParser (/cla-assistant/node_modules/body-parser/lib/types/json.js:134:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at /cla-assistant/node_modules/x-frame-options/index.js:6:5
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at /cla-assistant/src/server/app.js:29:9
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at expressInit (/cla-assistant/node_modules/express/lib/middleware/init.js:40:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at query (/cla-assistant/node_modules/express/lib/middleware/query.js:45:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at Function.handle (/cla-assistant/node_modules/express/lib/router/index.js:174:3)
    at EventEmitter.handle (/cla-assistant/node_modules/express/lib/application.js:174:10)
    at app (/cla-assistant/node_modules/express/lib/express.js:39:9)
    at /cla-assistant/node_modules/applicationinsights/out/AutoCollection/HttpRequests.js:76:25
    at ZoneDelegate.invoke (/cla-assistant/node_modules/zone.js/dist/zone-node.js:242:26)
    at Zone.run (/cla-assistant/node_modules/zone.js/dist/zone-node.js:113:43)
    at Function.CorrelationContextManager.runWithContext (/cla-assistant/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:47:21)
    at Server.<anonymous> (/cla-assistant/node_modules/applicationinsights/out/AutoCollection/HttpRequests.js:65:71)
    at ZoneDelegate.invokeTask (/cla-assistant/node_modules/zone.js/dist/zone-node.js:275:35)
    at Zone.runTask (/cla-assistant/node_modules/zone.js/dist/zone-node.js:151:47)
    at Server.ZoneTask.invoke (/cla-assistant/node_modules/zone.js/dist/zone-node.js:345:33)
    at emitTwo (events.js:106:13)
    at Server.emit (events.js:191:7)
    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

* Increase bodyparser limitaion from 1mb to 5mb.
KharitonOff pushed a commit that referenced this issue Dec 5, 2017
@MichaelTsengLZ
Bugfix: enlarge the body parser limitation. (#63)
419eca3 
* Bugfix: enlarge the body parser limitation.

When body parser parse the web hook event payload. It throw the error bellow.

PayloadTooLargeError: request entity too large
    at readStream (/cla-assistant/node_modules/raw-body/index.js:155:17)
    at getRawBody (/cla-assistant/node_modules/raw-body/index.js:108:12)
    at read (/cla-assistant/node_modules/body-parser/lib/read.js:77:3)
    at jsonParser (/cla-assistant/node_modules/body-parser/lib/types/json.js:134:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at /cla-assistant/node_modules/x-frame-options/index.js:6:5
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at /cla-assistant/src/server/app.js:29:9
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at expressInit (/cla-assistant/node_modules/express/lib/middleware/init.js:40:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at query (/cla-assistant/node_modules/express/lib/middleware/query.js:45:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at Function.handle (/cla-assistant/node_modules/express/lib/router/index.js:174:3)
    at EventEmitter.handle (/cla-assistant/node_modules/express/lib/application.js:174:10)
    at app (/cla-assistant/node_modules/express/lib/express.js:39:9)
    at /cla-assistant/node_modules/applicationinsights/out/AutoCollection/HttpRequests.js:76:25
    at ZoneDelegate.invoke (/cla-assistant/node_modules/zone.js/dist/zone-node.js:242:26)
    at Zone.run (/cla-assistant/node_modules/zone.js/dist/zone-node.js:113:43)
    at Function.CorrelationContextManager.runWithContext (/cla-assistant/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:47:21)
    at Server.<anonymous> (/cla-assistant/node_modules/applicationinsights/out/AutoCollection/HttpRequests.js:65:71)
    at ZoneDelegate.invokeTask (/cla-assistant/node_modules/zone.js/dist/zone-node.js:275:35)
    at Zone.runTask (/cla-assistant/node_modules/zone.js/dist/zone-node.js:151:47)
    at Server.ZoneTask.invoke (/cla-assistant/node_modules/zone.js/dist/zone-node.js:345:33)
    at emitTwo (events.js:106:13)
    at Server.emit (events.js:191:7)
    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

* Increase bodyparser limitaion from 1mb to 5mb.
KharitonOff pushed a commit that referenced this issue Feb 18, 2020
@MichaelTsengLZ
Bugfix: enlarge the body parser limitation. (#63)
5fbeacc 
* Bugfix: enlarge the body parser limitation.

When body parser parse the web hook event payload. It throw the error bellow.

PayloadTooLargeError: request entity too large
    at readStream (/cla-assistant/node_modules/raw-body/index.js:155:17)
    at getRawBody (/cla-assistant/node_modules/raw-body/index.js:108:12)
    at read (/cla-assistant/node_modules/body-parser/lib/read.js:77:3)
    at jsonParser (/cla-assistant/node_modules/body-parser/lib/types/json.js:134:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at /cla-assistant/node_modules/x-frame-options/index.js:6:5
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at /cla-assistant/src/server/app.js:29:9
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at expressInit (/cla-assistant/node_modules/express/lib/middleware/init.js:40:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at query (/cla-assistant/node_modules/express/lib/middleware/query.js:45:5)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/cla-assistant/node_modules/express/lib/router/index.js:317:13)
    at /cla-assistant/node_modules/express/lib/router/index.js:284:7
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)
    at Function.handle (/cla-assistant/node_modules/express/lib/router/index.js:174:3)
    at EventEmitter.handle (/cla-assistant/node_modules/express/lib/application.js:174:10)
    at app (/cla-assistant/node_modules/express/lib/express.js:39:9)
    at /cla-assistant/node_modules/applicationinsights/out/AutoCollection/HttpRequests.js:76:25
    at ZoneDelegate.invoke (/cla-assistant/node_modules/zone.js/dist/zone-node.js:242:26)
    at Zone.run (/cla-assistant/node_modules/zone.js/dist/zone-node.js:113:43)
    at Function.CorrelationContextManager.runWithContext (/cla-assistant/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:47:21)
    at Server.<anonymous> (/cla-assistant/node_modules/applicationinsights/out/AutoCollection/HttpRequests.js:65:71)
    at ZoneDelegate.invokeTask (/cla-assistant/node_modules/zone.js/dist/zone-node.js:275:35)
    at Zone.runTask (/cla-assistant/node_modules/zone.js/dist/zone-node.js:151:47)
    at Server.ZoneTask.invoke (/cla-assistant/node_modules/zone.js/dist/zone-node.js:345:33)
    at emitTwo (events.js:106:13)
    at Server.emit (events.js:191:7)
    at HTTPParser.parserOnIncoming [as onIncoming] (_http_server.js:546:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)

* Increase bodyparser limitaion from 1mb to 5mb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwquick @KharitonOff