Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot link cla to a repo #778

Closed
hi-rustin opened this issue Sep 27, 2021 · 9 comments
Closed

Cannot link cla to a repo #778

hi-rustin opened this issue Sep 27, 2021 · 9 comments
Assignees
Labels

Comments

@hi-rustin
Copy link

hi-rustin commented Sep 27, 2021

URL to the linked Repository or Organization

https://github.com/pingcap/tidb-tools

Steps to reproduce the problem

  1. try link the repo with any CLA gist
  2. it shows linked successfully

What is the expected result?

The CLA should be linked and works well.

What happens instead?

refresh the dashboard, the repo disappeared (even when I created the webhook)

Any other information? (attach screenshot if possible)

image
image

Also the request for this gist prompts a 403, but it is actually public.

image

{
	"gist": {
		"gist_url": "https://gist.github.com/c76097bc1e95534fc1998f99a3837d84",
		"gist_version": "4558b5d00f33e69e58432b89865fc8de0ea5cdeb"
	},
	"repoId": "64638071",
	"sharedGist": false
}

Used browser and browser version?

Firefox developer edition
93.0b9 (64-bit)

Any other tested browsers/devices(OK/FAIL):

@hi-rustin
Copy link
Author

hi-rustin commented Sep 27, 2021

I tried some of my personal repositories, using the same gist, and it works.

@Shegox
Copy link
Member

Shegox commented Sep 27, 2021

@hi-rustin,

just a quick guess, I haven't yet time to look into it in detail. Do you have third-party app restrictions enabled for your org?
https://docs.github.com/en/organizations/restricting-access-to-your-organizations-data/about-oauth-app-access-restrictions &
https://docs.github.com/en/organizations/restricting-access-to-your-organizations-data/approving-oauth-apps-for-your-organization

@hi-rustin
Copy link
Author

@hi-rustin,

just a quick guess, I haven't yet time to look into it in detail. Do you have third-party app restrictions enabled for your org?
https://docs.github.com/en/organizations/restricting-access-to-your-organizations-data/about-oauth-app-access-restrictions &
https://docs.github.com/en/organizations/restricting-access-to-your-organizations-data/approving-oauth-apps-for-your-organization

There are many repos under the organization that use it properly.

@Shegox
Copy link
Member

Shegox commented Sep 27, 2021

So I just had a couple of more minutes and that seems to not an issue, as other repos in the pingcap organizations are already using CLA-Assistant (e.g. https://github.com/pingcap/dm).

But I looked and I found something very weird. There seems to be an entry in the database associated with a different repository (repo id: 64638071). Did sometime ago a different repository with the same name exist?

Edit: I checked and it seems that there was a pincap/tidb-tools repository sometime ago and there exists as well a dozen signatures for it from ~2017.

@Shegox
Copy link
Member

Shegox commented Sep 27, 2021

Hi @hi-rustin,

I checked and it seems that there was a pincap/tidb-tools repository sometime ago and there exists as well a dozen signatures for it from ~2017. I updated it in the database and cleaned up the name. Can you try readding the CLA now and see if that works?

Also if you have the browser debug tools open, there should be an API call when the repo is configured and the response header there should be a trace id. Can you share that with me please to easier cross check the logs?

@hi-rustin
Copy link
Author

Also if you have the browser debug tools open, there should be an API call when the repo is configured and the response header there should be a trace id. Can you share that with me please to easier cross check the logs?

{
	"url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84",
	"forks_url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84/forks",
	"commits_url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84/commits",
	"id": "c76097bc1e95534fc1998f99a3837d84",
	"node_id": "MDQ6R2lzdGM3NjA5N2JjMWU5NTUzNGZjMTk5OGY5OWEzODM3ZDg0",
	"git_pull_url": "https://gist.github.com/c76097bc1e95534fc1998f99a3837d84.git",
	"git_push_url": "https://gist.github.com/c76097bc1e95534fc1998f99a3837d84.git",
	"html_url": "https://gist.github.com/c76097bc1e95534fc1998f99a3837d84",
	"files": {
		"cla": {
			"filename": "cla",
			"type": "text/plain",
			"language": null,
			"raw_url": "https://gist.githubusercontent.com/ngaut/c76097bc1e95534fc1998f99a3837d84/raw/4a2bd64a28c38e6fab85629266915bd45fbf3571/cla",
			"size": 6337,
			"truncated": false,
			"content": "PingCAP, Ltd.\nContributor License Agreement\nThank you for your interest in the open source project(s) managed by PingCAP, Ltd. (“PingCAP”). In order to clarify the intellectual property license granted with Contributions from any person or entity, PingCAP must have a Contributor License Agreement (“CLA”) on file that has been signed by each contributor, indicating agreement to the license terms below. This license is for your protection as a contributor as well as the protection of PingCAP and its other contributors and users; it does not change your rights to use your own Contributions for any other purpose.\n\nBy clicking “Accept” on this page You accept and agree to these terms and conditions for Your present and future Contributions submitted to PingCAP. In return, PingCAP shall consider Your Contributions for addition to the official PingCAP open source project(s) for which they were submitted. Except for the license granted herein to PingCAP and recipients of software distributed by PingCAP, You reserve all right, title, and interest in and to Your Contributions.\n\nDefinitions.\n\n“You” (or “Your”) shall mean the copyright owner or legal entity authorized by the copyright owner that is entering into this CLA with PingCAP. For legal entities, the entity making a Contribution and all other entities that control, are controlled by, or are under common control with that entity are considered to be a single Contributor. For the purposes of this definition, “control” means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.\n\n“Contribution” shall mean any code, documentation or other original works of authorship, including any modifications or additions to an existing work, that are intentionally submitted by You to PingCAP for inclusion in, or documentation of, any of the products owned or managed by PingCAP (the “Work”). For the purposes of this definition, “submitted” means any form of electronic, verbal, or written communication sent to PingCAP or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, PingCAP for the purpose of discussing and improving the Work, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Contribution.”\n\nGrant of Copyright License. Subject to the terms and conditions of this CLA, You hereby grant to PingCAP and to recipients of software distributed by PingCAP a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce, prepare derivative works of, publicly display, publicly perform, sublicense, and distribute Your Contributions and such derivative works.\n\nGrant of Patent License. Subject to the terms and conditions of this CLA, You hereby grant to PingCAP and to recipients of software distributed by PingCAP a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by You that are necessarily infringed by Your Contribution(s) alone or by combination of Your Contribution(s) with the Work to which such Contribution(s) were submitted. If any entity institutes patent litigation against You or any other entity (including a cross-claim or counterclaim in a lawsuit) alleging that Your Contribution, or the Work to which You have contributed, constitutes direct or contributory patent infringement, then any patent licenses granted to that entity under this CLA for that Contribution or Work shall terminate as of the date such litigation is filed.\n\nYou represent and warrant that You are legally entitled to grant the above license. If You are an individual and Your employer(s) has rights to intellectual property that You create that includes Your Contributions, You represent that You have received permission to make Contributions on behalf of that employer, that Your employer has waived such rights for Your Contributions to PingCAP, or that Your employer has entered into a separate CLA with PingCAP covering Your Contributions. If You are a Company, You represent further that each employee making a Contribution to PingCAP under the Company’s name is authorized to submit Contributions on behalf of the Company.\n\nYou represent and warrant that each of Your Contributions is Your original creation (see section 7 for submissions on behalf of others). You represent and warrant that, to Your knowledge, none of Your Contributions infringe, violate, or misappropriate any third party intellectual property or other proprietary rights.\n\nYou are not expected to provide support for Your Contributions, except to the extent You desire to provide support. You may provide support for free, for a fee, or not at all. Unless required by applicable law or agreed to in writing, except for the warranties set forth above, You provide Your Contributions on an “AS IS” BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE.\n\nShould You wish to submit work that is not Your original creation, You may submit it to PingCAP separately from any Contribution, identifying the complete details of its source and of any license or other restriction (including, but not limited to, related patents, trademarks, and license agreements) of which You are personally aware, and conspicuously marking the work as “Submitted on behalf of a third-party: [named here]”.\n\nYou agree to notify PingCAP of any facts or circumstances of which You become aware that would make the above representations and warranties inaccurate in any respect.\n\nIf You are entering into this CLA as a Company, You represent and warrant that the individual accepting this CLA is duly authorized to enter into this CLA on the Company’s behalf."
		}
	},
	"public": true,
	"created_at": "2016-04-03T04:13:27Z",
	"updated_at": "2020-11-19T09:56:43Z",
	"description": "cla",
	"comments": 0,
	"user": null,
	"comments_url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84/comments",
	"owner": {
		"login": "ngaut",
		"id": 878009,
		"node_id": "MDQ6VXNlcjg3ODAwOQ==",
		"avatar_url": "https://avatars.githubusercontent.com/u/878009?v=4",
		"gravatar_id": "",
		"url": "https://api.github.com/users/ngaut",
		"html_url": "https://github.com/ngaut",
		"followers_url": "https://api.github.com/users/ngaut/followers",
		"following_url": "https://api.github.com/users/ngaut/following{/other_user}",
		"gists_url": "https://api.github.com/users/ngaut/gists{/gist_id}",
		"starred_url": "https://api.github.com/users/ngaut/starred{/owner}{/repo}",
		"subscriptions_url": "https://api.github.com/users/ngaut/subscriptions",
		"organizations_url": "https://api.github.com/users/ngaut/orgs",
		"repos_url": "https://api.github.com/users/ngaut/repos",
		"events_url": "https://api.github.com/users/ngaut/events{/privacy}",
		"received_events_url": "https://api.github.com/users/ngaut/received_events",
		"type": "User",
		"site_admin": false
	},
	"forks": [],
	"history": [
		{
			"user": {
				"login": "ngaut",
				"id": 878009,
				"node_id": "MDQ6VXNlcjg3ODAwOQ==",
				"avatar_url": "https://avatars.githubusercontent.com/u/878009?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/ngaut",
				"html_url": "https://github.com/ngaut",
				"followers_url": "https://api.github.com/users/ngaut/followers",
				"following_url": "https://api.github.com/users/ngaut/following{/other_user}",
				"gists_url": "https://api.github.com/users/ngaut/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/ngaut/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/ngaut/subscriptions",
				"organizations_url": "https://api.github.com/users/ngaut/orgs",
				"repos_url": "https://api.github.com/users/ngaut/repos",
				"events_url": "https://api.github.com/users/ngaut/events{/privacy}",
				"received_events_url": "https://api.github.com/users/ngaut/received_events",
				"type": "User",
				"site_admin": false
			},
			"version": "4558b5d00f33e69e58432b89865fc8de0ea5cdeb",
			"committed_at": "2016-04-03T04:16:31Z",
			"change_status": {
				"total": 4,
				"additions": 2,
				"deletions": 2
			},
			"url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84/4558b5d00f33e69e58432b89865fc8de0ea5cdeb"
		},
		{
			"user": {
				"login": "ngaut",
				"id": 878009,
				"node_id": "MDQ6VXNlcjg3ODAwOQ==",
				"avatar_url": "https://avatars.githubusercontent.com/u/878009?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/ngaut",
				"html_url": "https://github.com/ngaut",
				"followers_url": "https://api.github.com/users/ngaut/followers",
				"following_url": "https://api.github.com/users/ngaut/following{/other_user}",
				"gists_url": "https://api.github.com/users/ngaut/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/ngaut/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/ngaut/subscriptions",
				"organizations_url": "https://api.github.com/users/ngaut/orgs",
				"repos_url": "https://api.github.com/users/ngaut/repos",
				"events_url": "https://api.github.com/users/ngaut/events{/privacy}",
				"received_events_url": "https://api.github.com/users/ngaut/received_events",
				"type": "User",
				"site_admin": false
			},
			"version": "d21c0c4245e949287422e3db38fc12dfe4fc78a8",
			"committed_at": "2016-04-03T04:15:16Z",
			"change_status": {
				"total": 0,
				"additions": 0,
				"deletions": 0
			},
			"url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84/d21c0c4245e949287422e3db38fc12dfe4fc78a8"
		},
		{
			"user": {
				"login": "ngaut",
				"id": 878009,
				"node_id": "MDQ6VXNlcjg3ODAwOQ==",
				"avatar_url": "https://avatars.githubusercontent.com/u/878009?v=4",
				"gravatar_id": "",
				"url": "https://api.github.com/users/ngaut",
				"html_url": "https://github.com/ngaut",
				"followers_url": "https://api.github.com/users/ngaut/followers",
				"following_url": "https://api.github.com/users/ngaut/following{/other_user}",
				"gists_url": "https://api.github.com/users/ngaut/gists{/gist_id}",
				"starred_url": "https://api.github.com/users/ngaut/starred{/owner}{/repo}",
				"subscriptions_url": "https://api.github.com/users/ngaut/subscriptions",
				"organizations_url": "https://api.github.com/users/ngaut/orgs",
				"repos_url": "https://api.github.com/users/ngaut/repos",
				"events_url": "https://api.github.com/users/ngaut/events{/privacy}",
				"received_events_url": "https://api.github.com/users/ngaut/received_events",
				"type": "User",
				"site_admin": false
			},
			"version": "2c18c808ce23915248359d9159e2357b3b630b10",
			"committed_at": "2016-04-03T04:13:26Z",
			"change_status": {
				"total": 27,
				"additions": 27,
				"deletions": 0
			},
			"url": "https://api.github.com/gists/c76097bc1e95534fc1998f99a3837d84/2c18c808ce23915248359d9159e2357b3b630b10"
		}
	],
	"truncated": false
}

Thanks for your help!

@hi-rustin
Copy link
Author

@Shegox I consulted with my colleague and it did go through renaming and it did go through archiving and reopening.

@Shegox
Copy link
Member

Shegox commented Sep 28, 2021

Hi @hi-rustin,
did it work now? I can see that the CLA shows up for signing here: https://cla-assistant.io/pingcap/tidb-tools

@hi-rustin
Copy link
Author

Hi @hi-rustin,
did it work now? I can see that the CLA shows up for signing here: https://cla-assistant.io/pingcap/tidb-tools

It works!
Thanks for your help again! 💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants