Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to show all signers for any version, not just the last one #79

Closed
spf13 opened this issue Nov 5, 2015 · 5 comments
Closed

need to show all signers for any version, not just the last one #79

spf13 opened this issue Nov 5, 2015 · 5 comments

Comments

@spf13
Copy link

spf13 commented Nov 5, 2015

For the CLA-assistant to be usable it needs to capture and show all contributors and when they signed and for what version of the CLA. As it is currently written any modification to the CLA virtually resets a record of all signers rather than showing the list of users who accepted a CLA for their contributions and what the version of the CLA that they accepted.

The readme states "You as repository owner can review the list of users who signed your CLA for each version of it." Perhaps there is a way to do it but with the current UI I only see the latest CLA signatures. I went from a list of 141 to 1 after making a small change to the CLA and have no way of getting the list of the previous 141 anymore.

I'm happy to help with this if I can.

@KharitonOff
Copy link
Contributor

Good point! 👍
We have had this functionality in an older version of CLA assistant, but it was skipped later on by redesign.
Your request is absolutely valid, let's bring it back...

@KharitonOff
Copy link
Contributor

@spf13 , could you check the new version, please? Does it work for you as expected?

@spf13
Copy link
Author

spf13 commented Nov 9, 2015

Yes, this works... but it's a bit weird to have to export the list multiple times.. I can see why some may want this, but it would be great to have an export of all signings in one file as well.

@KharitonOff
Copy link
Contributor

Ok, I see... Would you expect a list with user name as a unique key or username + gist version as a unique key?

Name Version
User A 1
User B 2
User C 2

or

Name Version
User A 1
User B 2
User B 1
User C 2

@spf13
Copy link
Author

spf13 commented Nov 11, 2015

I think the latter is better. I can filter it on my end if I need to.
On Wed, Nov 11, 2015 at 3:45 AM Anton notifications@github.com wrote:

Ok, I see... Would you expect a list with user name as a unique key or
username + gist version as a unique key?
Name Version User A 1 User B 2 User C 2

or
Name Version User A 1 User B 2 User B 1 User C 2


Reply to this email directly or view it on GitHub
#79 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants