feat: migration assistant - OAuth App <> GitHub Apps #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+266
to
+288
| app.all('/github/webhooks', async (req, res) => { | ||
| const signature = req.get('X-Hub-Signature') | ||
| if (!(await verifyWebhookSignature( | ||
| config.server.github.app.webhookSecret, | ||
| JSON.stringify(req.body), | ||
| signature | ||
| ))) { | ||
| return res.status(401).send('Cannot verify webhook signature') | ||
| } | ||
| const event = req.get('X-GitHub-Event') | ||
| const hook = webhooks[event] | ||
| if (!hook) { | ||
| return res.status(400).send('Unsupported event') | ||
| } | ||
| if (!hook.accepts(req)) { | ||
| return res.status(204).send('This webhook performed no action') | ||
| } | ||
| if (isRudundantWebhook(req)) { | ||
| console.log(`Skip redundant webhook for the PR ${req.args.pull_request.html_url} on PR action "${req.args.action}"`) | ||
| return res.status(202).send('This seems to be a redundant webhook. Probably there are two webhooks registered: org- and repo-webhook') | ||
| } | ||
| return hook.handle(req, res) | ||
| }) |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| req.session.next = null | ||
| logger.debug('Finish processing authentication callback after passport authenticate') | ||
| } | ||
| githubCallbackPost |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| passport.authenticate('github-app-auth', { | ||
| failureRedirect: '/failure?failure=app-auth' | ||
| }), | ||
| githubCallbackPost |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Work in Progress.