Enable textarea and hidden fields support

[mickaelandrieu]

Hello @thojansen,

I think this is the only required update to fix #143.

Also, I need to display a textarea (this is why I've found your issue), for instance to ask for a postal address.

What do you think?

[review-ninja]

[coveralls]

Coverage remained the same at 91.268% when pulling 2c952d0 on mickaelandrieu:added-hidden-and-textarea-support into a49f8ed on cla-assistant:master.

[coveralls]

Coverage remained the same at 91.268% when pulling 1e6c1ae on mickaelandrieu:added-hidden-and-textarea-support into a49f8ed on cla-assistant:master.

[KharitonOff]

👍 thank you for your PR. Can you test the changes in https://preview.cla-assistant.io please?

[mickaelandrieu]

@KharitonOff Yes I will give a try today, thanks for the merge. I have 1 question regarding the way the data are stored on your service: can you confirm this is not stored on SAP servers (for the mongodb part)? This is a very important information for me (should we use the service or should we host it ?).

[KharitonOff]

@mickaelandrieu Yes, I can confirm that the data is not stored on SAP servers (yet), we use mlab.com as mongodb service provider. However I can't say how long we'll keep the status quo, mid- or longterm we would like to move to our own infrastructure (based on CloudFoundry), but there are no concrete plans so far.

[mickaelandrieu]

@KharitonOff textarea feature works as expected (for my needs)

As I don't understand who can be interested by a hidden field, I don't know how to test it: is it only to pass data? And if yes, why?

Regarding the data storage, will we be notified if the data are moved to SAP servers "before"? It's very important for us to ensure our contributors that their data are not offered to any company, at least, not used by any company.

[thojansen]

@mickaelandrieu we had a discussion regarding this #141 and have changed our ToS as a reaction of that issue.
https://gist.github.com/CLAassistant/3a73e4cd729c9d0a6e30/revisions

This should clarify how the data stored can be used.

..for purposes of operating and improving the Website and Tool

SAP has no interest in using that data for any other purposes and the physical location of the data storage will not change that. Legally the offered service is bound to the ToS.

[mickaelandrieu]

Thnks for the additional information @thojansen, it's fair :)