3 bugfixes and 2 features #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelTsengLZ
commented
Dec 22, 2017
| token: args.token | ||
| } | ||
| }; | ||
| ClaApi.validatePullRequests(req, () => { }); |
There was a problem hiding this comment.
@KharitonOff Do you specifically just want to check all the repo pull requests instead of org pull requests or shared CLA orgs/repos pull reqeusts?
There was a problem hiding this comment.
@MichaelTsengLZ actually yes, my intention was to reduce the number of calls, because this function is called every time a user signs a CLA. I assumed, that in 90% of cases the user has only one open PR in the certain repo, where he/she comes from to sign the CLA. In other cases I would take in count that the repo/org owner has to trigger "Recheck PRs" button manualy.
But since we use user-PR cache it should be ok, to check all PRs of the linked item as a fallback.
…getCombinedStatus' to 'getCombinedStatusForRef'
…equest is not found. We should validate shared CLA org/repo or org.
…l request signed or not instead of all the committers.
…org. linkedItem.org will throw error since linkedItem is null. What's more, we should delete those stored pull requests.
MichaelTsengLZ
force-pushed
the
master
branch
from
93229fb
to
df9502c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfixes:
New GitHub node package changes getting combined status API from 'getCombinedStatus' to 'getCombinedStatusForRef
When the input is undefined or null, hasNextPage() API of GitHub node package will throw an error. Then admin homepage will not show anything.
For those contributors don't have cached pull request, we should validate not only the repo pull request but also validate to shared gist repos/orgs accordingly.
Small features:
Add config settings to allow only need the submitter to sign instead of all the committers of a pull request.
When user change name, we should also identify their previous signature.