Bugfix: Consider old style CLA documents without userId #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem #1: old CLA documents don't match the query with userId -> user is requested to sign the CLA again, this doesn't work either, because of index of the document, which doesn't consider the userId. solution: extend query with search parameter, considering nonexistend userId problem #2: method isSignificantPullRequest expects user token as mandatory attribute, in case user clicks the "recheck" link in the PR comment this method is also called, but there is no token provided solution: use token of the linked item if there is no user token
|
Good catch. I should consider the compatibility and the case that contributor will click 'recheck' link. 👍 👍 👍 |
KharitonOff
added a commit
that referenced
this pull request
Feb 18, 2020
Bugfix: Consider old style CLA documents without userId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MichaelTsengLZ could you review my changes, please? Are you ok with it?
problem 1: old CLA documents don't match the query with userId -> user is requested to sign the CLA again, this doesn't work either, because of index of the document, which doesn't consider the userId.
solution: extend query with search parameter, considering nonexistend userId
problem 2: method isSignificantPullRequest expects user token as mandatory attribute, in case user clicks the "recheck" link in the PR comment this method is also called, but there is no token provided
solution: use token of the linked item if there is no user token