Faster corpus pruning

claabs · Jan 2, 2022 · f4fc7a2 · f4fc7a2
1 parent a53c883
commit f4fc7a2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "markov-strings-db",
-  "version": "4.1.1",
+  "version": "4.1.2",
   "description": "A Markov string generator that utilizes a relational SQL database",
   "main": "dist/src/index.js",
   "types": "dist/src/index.d.ts",

diff --git a/src/index.ts b/src/index.ts
@@ -530,12 +530,9 @@ export default class Markov {
    * Remove any dangling corpus entries with 0 fragments pointing to them
    */
   private static async pruneDanglingCorpusEntries(): Promise<void> {
-    const subQuery = MarkovFragment.createQueryBuilder('fragment').where(
-      'fragment.corpusEntry = corpusEntry.id'
-    );
     const emptyCorpuses = await MarkovCorpusEntry.createQueryBuilder('corpusEntry')
-      .where(`NOT EXISTS (${subQuery.getQuery()})`)
-      .setParameters(subQuery.getParameters())
+      .leftJoin('corpusEntry.fragments', 'fragment')
+      .where('fragment.corpusEntry IS NULL')
       .getMany();
     await MarkovCorpusEntry.remove(emptyCorpuses);
   }