Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python works in Windows, including MKL and/or GPU support #128

Merged
merged 12 commits into from
Oct 27, 2016

Conversation

mattr1
Copy link
Collaborator

@mattr1 mattr1 commented Oct 26, 2016

Windows Python build works correctly with MKL, GPU, none, or both. Updated documentation also. MKL and GPU support complicated setup.py.in somewhat, but I tried to keep it as clean as possible.

Tested on Windows and Ubuntu Linux, with normal, MKL, GPU, and MKL+GPU. rnnlm.py works in all 8 cases.

@neubig neubig merged commit 517b025 into clab:master Oct 27, 2016
@neubig
Copy link
Contributor

neubig commented Oct 27, 2016

Thanks a lot!

@mattr1
Copy link
Collaborator Author

mattr1 commented Oct 27, 2016

No problem. Thanks for integrating the changes quickly.

Matt

From: Graham Neubig [mailto:notifications@github.com]
Sent: Thursday, October 27, 2016 7:55 AM
To: clab/dynet dynet@noreply.github.com
Cc: Matt Richardson mattri@microsoft.com; Author author@noreply.github.com
Subject: Re: [clab/dynet] Python works in Windows, including MKL and/or GPU support (#128)

Thanks a lot!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclab%2Fdynet%2Fpull%2F128%23issuecomment-256665043&data=02%7C01%7Cmattri%40microsoft.com%7Ceacdaa83a0204977c1ff08d3fe792f1a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636131768841279972&sdata=HQzNFE9N1zMCIMn36r5JiQg%2F34a26UyC8LUQaqztpT4%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVS0dImksRV6lC_4DPRwDFJCsjKyVfquks5q4LsvgaJpZM4KgtPo&data=02%7C01%7Cmattri%40microsoft.com%7Ceacdaa83a0204977c1ff08d3fe792f1a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636131768841279972&sdata=swP9TwQIle%2BtH4ObGEOXcTb7XwxeuescMpldH1k1FZk%3D&reserved=0.

@mattr1 mattr1 deleted the mattri/winpython branch February 10, 2017 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants