Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential temp file vulnerability #5

Closed
PanderMusubi opened this issue Apr 25, 2023 · 4 comments
Closed

Fix potential temp file vulnerability #5

PanderMusubi opened this issue Apr 25, 2023 · 4 comments

Comments

@PanderMusubi
Copy link
Contributor

Can you fix this armbian/build#5095 (comment)

Perhaps comment out all and remove the exit.
@clach04 clach04 changed the title Fix temp file vulnerability Fix potential temp file vulnerability Apr 25, 2023
@clach04
Copy link
Owner

clach04 commented Apr 25, 2023

from armbian/build#5095 (comment)

It's only purpose is to avoid temp file vulnerabilities in scripts. You pull in code from somewhere that's not under your own control and the exit statement might vanish at any time without anyone noticing. That's almost recipe for disaster :)

@clach04 clach04 mentioned this issue Apr 25, 2023
Merged
6 tasks
clach04 added a commit that referenced this issue Apr 25, 2023
@clach04
Fix issues #5 - remove unused code
8469e3f
@clach04 clach04 closed this as completed Apr 25, 2023
@PanderMusubi
Copy link
Contributor Author

Thanks. Can you make a new release as Armbian pulls the files based on release number.

@clach04
Copy link
Owner

clach04 commented Apr 26, 2023

https://github.com/clach04/fake_vcgencmd/releases/tag/0.0.2

@PanderMusubi
Copy link
Contributor Author

Thanks. FYI, the new version is also fine when inspected with checkbashisms vcgencmd. Handy script for also next versions. See also armbian/build#5100 and #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PanderMusubi @clach04