Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy without usr/psw authentication and IP-based auntenthication #73

Merged
merged 1 commit into from
May 30, 2023

Conversation

gitrid
Copy link

@gitrid gitrid commented May 24, 2023

Chromium based solutions do not support user/password proxy authentication and given the fact that it is outdated/unsecure option it will rather not change in future. To bypass this, this request:

  • supports setting up proxies without username and password,
  • adds additional authentication method - ONLY_HOST_IP - to avoid leaving proxy without any security.

No breaking changes, although I don't know why in case of proxies without username and password this check_alive directly reaching to proxy fails:
result = requests.get("http://" + ip_address + ":8899", timeout=3)
and returns this error (after removing timeout restriction):
Unable to connect Tinyproxy was unable to connect to the remote web server. Generated by [tinyproxy](https://tinyproxy.github.io/) version 1.11.0.
However, using the very same IP as a proxy works without issues, hence I updated the line to:
result = requests.get("http://ipecho.net/plain", proxies={'http': "http://" + ip_address + ":8899"}, timeout=3).

Create docker-image.yml

Update main.yml

Added support to launch without usr and passw

Skip auth test

Update .gitlab-ci.yml file

Ci update

Gitlab CI update

config change

Up

up

trying configs

typo

Added only_host_ip restriction

debugging check_alive

debuging checkalive

debugging checkalive

further access debuging

further debugging

wrong replace

correcting 403 error

cleaning up

Cleaning up before contribution

Further cleaning up

Return test

Removing variable checking to pass tests

Updated test

Preparing for contribution
@claffin claffin merged commit c2c8636 into claffin:main May 30, 2023
3 checks passed
@claffin
Copy link
Owner

claffin commented May 30, 2023

Thank you for the contribution @gitrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants