Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Add segment-amplitude integration #27

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

gertdrui
Copy link
Contributor

This adds the segment-amplitude library to iOS and Android when enabled via key ENABLE_AMPLITUDE_INTEGRATION.
Also fixes segment-branch incorrect import path on iOS.

iOS Analytics had to be kicked back to 3.7 since segment-amplitude has that version pinned for now. The next version removes that version pin but it's not available in cocoapods yet.

Closes issue #26

@@ -15,8 +15,9 @@ A new flutter plugin project.
s.source_files = 'Classes/**/*'
s.public_header_files = 'Classes/**/*.h'
s.dependency 'Flutter'
s.dependency 'Analytics', '4.0.1'
s.dependency 'Analytics', '3.7.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a downgrade needed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MaiKaY, I believe @gertdrui answered that in the comment of the PR.

iOS Analytics had to be kicked back to 3.7 since segment-amplitude has that version pinned for now. The next version removes that version pin but it's not available in cocoapods yet.

@MaiKaY
Copy link
Contributor

MaiKaY commented Aug 7, 2020

Hi @gertdrui,
do you have time to quickly answer my question above?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants