Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Installation via Dart Code #49

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Conversation

esarbanis
Copy link
Contributor

@esarbanis esarbanis commented Jan 10, 2021

Allows the plugin to be configured (installed) via Dart Code, by exposing a config method in the Dart API which set's up the native library with the passed SegmentConfig.

The old functionality still works for compatibility reasons.

Fixes #22

@tzvc
Copy link
Contributor

tzvc commented Jul 30, 2021

Aaah would love to see that merged! Any updates ?

@ariefwijaya
Copy link
Contributor

This will be helpful , we can easily manage the WriteKey without committing them , any updates?

@ariefwijaya
Copy link
Contributor

Hi, would you please check this PR since this has no conflict and we need this amazing feature :)

@channainfo
Copy link

I also need this feature, any updates please?

@MaiKaY
Copy link
Contributor

MaiKaY commented Sep 29, 2021

Hi @esarbanis,
thanks a lot for your contribution and the great work you did.

I would like to merge this today but I am unsure how to proceed with versioning it. Do you think it's 3.2.0 or even 4.0.0?

(any thoughts here @theochampion @channainfo @ariefwijaya)

@ariefwijaya
Copy link
Contributor

@MaiKaY, Since this is a kind of breaking change, I think 4.0.0 is better

@esarbanis
Copy link
Contributor Author

@ariefwijaya I am not sure this is a breaking change as the old setup methods work as well, so people who already use it with the previous configuration should be able to upgrade with no break. Or at least this is the idea 😅 🤞

@MaiKaY
Copy link
Contributor

MaiKaY commented Sep 30, 2021

Hi @esarbanis,

Or at least this is the idea 😅 🤞

May I ask you @esarbanis to validate this before I merge and release version 3.2.0? I really appreciate your help here.

@esarbanis
Copy link
Contributor Author

@MaiKaY I used the example app to send events to a test segment source, without using the dart configuration, and I got the messages. So I think it is safe to say that this change is backward compatible.

@MaiKaY MaiKaY merged commit 11351d0 into claimsforce-gmbh:master Sep 30, 2021
@MaiKaY
Copy link
Contributor

MaiKaY commented Sep 30, 2021

@esarbanis, great! I just merged and released version 3.2.0. Thanks again for your support here.

@ariefwijaya
Copy link
Contributor

@MaiKaY ,
Hi, I'm a bit confused.
From the segment dashboard, we have different WRITE KEY for ios and android. How to use those keys since this PR only supports 1 key?

@MaiKaY
Copy link
Contributor

MaiKaY commented Oct 8, 2021

Hi @ariefwijaya,
since the configuration is written in Dart you can add if conditions to check which OS is in use, based on each OS you could have different WRITE KEYS. Does this make sense to you @ariefwijaya?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Would you consider changing the installation process to be pure Dart?
5 participants