Collapse getProperty() and property @properties from PdfFileReader into one

[acsor]

PdfFileReader has about 9 cases of the following pattern. Take as a concrete example isEncrypted:

    def getIsEncrypted(self):
        return "/Encrypt" in self._trailer

    isEncrypted = property(getIsEncrypted)
    """
    Read-only boolean property showing whether this PDF file is encrypted.
    Note that this property, if True, will remain True even after the
    :meth:`decrypt()<PdfFileReader.decrypt>` method is called.
    """

I do not see any real utility in this code style and it actually causes more verbosity. I invite to change these many cases were getProperty() == property to something like (take isEncrypted as an example again):

"""
Read-only boolean property showing whether this PDF file is encrypted.
Note that this property, if True, will remain True even after the
:meth:`decrypt()<PdfFileReader.decrypt>` method is called.
"""
@property
def isEncrypted(self):
        return "/Encrypt" in self._trailer

Please note that isEncrypted's docstring seems misleading. Indeed, I know of no default caching for property decorators, as attested here.

[acsor]

I introduced this modification in Remove redundant @Property accessors from PdfFileReader. . Before I close this issue we can eventually discuss the change.

[claird]

"isEncrypted" is better style than "getIsEncrypted" in any realistic sense. Cameron Laird, vice president We make computers work for people.

…

On Fri, Oct 5, 2018 at 5:13 PM Oscar ***@***.***> wrote: I introduced this modification in Remove redundant @Property accessors from PdfFileReader. <f020613>. Before I close this issue we can eventually discuss the change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAbN9AGkOQ3pliFWehw883YkIVmTp2iyks5uh9mDgaJpZM4W0Mxr> .

[acsor]

Yeah, definitely. Also, the past getIsEncrypted() code was so minimal that I was left wondering why no one did like so in the first place :'-).