Skip to content

Commit

Permalink
Fix e2e Flaky Apps/Job BackoffLimit test
Browse files Browse the repository at this point in the history
This fix is linked to the PR kubernetes#51153 that introduce the
JobSpec.BackoffLimit.
Previously the Timeout used in the test was too agressive and generates
flaky test execution. Now it used the default framework.JobTimeout used
in others tests.
  • Loading branch information
clamoriniere1A committed Sep 14, 2017
1 parent 1bdcfa5 commit 0d7182f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/apps/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ var _ = SIGDescribe("Job", func() {
Expect(err).NotTo(HaveOccurred())
By("Ensuring job exceed backofflimit")

err = framework.WaitForJobFailure(f.ClientSet, f.Namespace.Name, job.Name, time.Duration(30)*time.Second, "BackoffLimitExceeded")
err = framework.WaitForJobFailure(f.ClientSet, f.Namespace.Name, job.Name, framework.JobTimeout, "BackoffLimitExceeded")
Expect(err).NotTo(HaveOccurred())

By("Checking that only one pod created and status is failed")
Expand Down

0 comments on commit 0d7182f

Please sign in to comment.