Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.0-1.7.2 - Enhancement: Add option to make connection via URL params #163

Merged
merged 7 commits into from
Jul 3, 2023
Merged

1.7.0-1.7.2 - Enhancement: Add option to make connection via URL params #163

merged 7 commits into from
Jul 3, 2023

Conversation

johngribbin
Copy link
Contributor

@johngribbin johngribbin commented Jun 29, 2023 •
edited

This PR updates /connect route to include the option to pass connection details via URL params. Params are:

  • address
  • rune
  • type
  • value

For example:

http://localhost:5173/connect?address=03093b030028e642fc3b9a05c8eb549f202958e92143da2e85579b92ef0f49cc7d@localhost:7272&rune=rLiwnD_eiPt5js1TUaNBoj0rX24KU2IzE3NCm5sL5uw9Ng==&type=direct&value=ws:

Note - address & rune are mandatory. type and value will default to the clams proxy like the app does already.

@johngribbin johngribbin changed the base branch from master to develop June 29, 2023 08:44
@johngribbin johngribbin changed the title Enhancement: Add option to make connection via connection route params 1.7.0-1.7.2 - Enhancement: Add option to make connection via connection route params Jun 29, 2023
@socket-security
Copy link

socket-security bot commented Jun 29, 2023 •
edited

undefined. Learn more about Socket for GitHub ↗︎

@johngribbin johngribbin marked this pull request as draft June 29, 2023 08:54
@johngribbin johngribbin marked this pull request as ready for review June 30, 2023 14:41
@johngribbin johngribbin changed the title 1.7.0-1.7.2 - Enhancement: Add option to make connection via connection route params 1.7.0-1.7.2 - Enhancement: Add option to make connection via URL params Jun 30, 2023
aaronbarnardsound
aaronbarnardsound approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@aaronbarnardsound aaronbarnardsound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aaronbarnardsound
Copy link
Member

Closes #113

@johngribbin johngribbin merged commit 97cb83a into develop Jul 3, 2023
1 check passed
@aaronbarnardsound aaronbarnardsound deleted the feature/qr-connect branch July 9, 2023 22:14
@aaronbarnardsound aaronbarnardsound mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbarnardsound aaronbarnardsound aaronbarnardsound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johngribbin @aaronbarnardsound