Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.1-0.1.2: Enhancement - Exchange Rate API #152

Merged
merged 6 commits into from
Apr 10, 2023

Conversation

lnbc1QWFyb24
Copy link
Member

This PR connects Clams to a new server endpoint: https://api.clams.tech which has a new codebase. Exchange rates will be fetched and cached by the server, and the app will fetch from there instead. This will help with rate limits on the external exchange rate API's.
To save bandwidth the app will only fetch the exchange rate for the fiat denomination that is set in the app. A new exchange rate will be fetched every 5 minutes or when the fiat denomination is changed.

The wsproxy lives at the /ws-proxy route on the new server and Clams now connects to that.
The https proxy for lnurl calls lives at /http-proxy.

Closes #144

@lnbc1QWFyb24
Copy link
Member Author

I also updated the Sveltekit dependency to fix a couple of security alerts.

@socket-security
Copy link

socket-security bot commented Apr 10, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Ignoring: @sveltejs/kit@1.15.2

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@sveltejs/kit@1.15.2 1.8.4...1.15.2 None +0/-0 svelte-admin

@lnbc1QWFyb24
Copy link
Member Author

@SocketSecurity ignore @sveltejs/kit@1.15.2

Copy link
Contributor

@johngribbin johngribbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a good play around, dont see any issues! app actually feels a little faster or is it just me??

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 1e6bd63 into develop Apr 10, 2023
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the enhancement/price-api branch April 10, 2023 21:52
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants