Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19 ダイバーログのCSVエクスポートのロジック追加 #34

Merged
merged 3 commits into from Mar 5, 2018

Conversation

umamo
Copy link
Collaborator

@umamo umamo commented Feb 28, 2018

  • テスト実行時にthreetenbpが動作するよう追加
  • 外部保存が必要なため、外部ディレクトリ用のパーミッション設定を追加
  • DummyFragmentにサンプルの呼び方を記載

* テスト実行時にthreetenbpが動作するよう追加
* 外部保存が必要なため、外部ディレクトリ用のパーミッション設定を追加
* DummyFragmentにサンプルの呼び方を記載
@yoshida-cw
Copy link
Collaborator

DummyFragmentにサンプルの呼び方を記載

DummyFragment.javaには特に何も書いてないようだけど、↓でOK?

MainActivity.java

getSupportFragmentManager().beginTransaction()
                .replace(R.id.fragment, new DummyFragment())
                .commit();

@yoshida-cw
Copy link
Collaborator

外部保存が必要なため、外部ディレクトリ用のパーミッション設定を追加

手元のエミュレータ(Android 4.4 KitKat)ではRead-Only領域に書き込もうとしてエラーが出ました。
こちらの環境のせいな気がするので、もう少し調べてみます。
動作確認込のレビューは他の2人に投げます。

03-01 07:52:35.124 5118-5118/com.slymapp.diverlog D/EXPORT_FILE: /storage/sdcard/DiverLogList.csv
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err: java.io.IOException: open failed: EROFS (Read-only file system)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at java.io.File.createNewFile(File.java:946)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at com.slymapp.diverlog.domain.DiverLogCsvExporter.exportAllLog(DiverLogCsvExporter.java:31)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at com.slymapp.diverlog.view.DummyFragment$1.onClick(DummyFragment.java:30)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at android.view.View.performClick(View.java:4438)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at android.view.View$PerformClick.run(View.java:18422)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at android.os.Handler.handleCallback(Handler.java:733)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at android.os.Handler.dispatchMessage(Handler.java:95)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at android.os.Looper.loop(Looper.java:136)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at android.app.ActivityThread.main(ActivityThread.java:5017)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at java.lang.reflect.Method.invokeNative(Native Method)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at java.lang.reflect.Method.invoke(Method.java:515)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at dalvik.system.NativeStart.main(Native Method)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err: Caused by: libcore.io.ErrnoException: open failed: EROFS (Read-only file system)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at libcore.io.Posix.open(Native Method)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at libcore.io.BlockGuardOs.open(BlockGuardOs.java:110)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err:     at java.io.File.createNewFile(File.java:939)
03-01 07:52:35.124 5118-5118/com.slymapp.diverlog W/System.err: 	... 13 more

@Override
public void onClick(View view) {
DiverLogExporter exporter = new DiverLogCsvExporter();
exporter.exportAllLog(getContext(), "DiverLogList.csv");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporterの呼び出し方はこんな感じです。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DummyFragmentの呼び方のことと読み違えてた。
Exporterのサンプルは理解しました。

Copy link
Collaborator

@yoshida-cw yoshida-cw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

無事に動作確認できました。

@yoshida-cw yoshida-cw merged commit 484007b into master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants