Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when creating an "error view", only "raw" parameters are recodred in the view metadata #233

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

keighrim
Copy link
Member

@keighrim keighrim commented Jul 1, 2024

fixes #232.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.04%. Comparing base (45ef237) to head (41b0a96).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
+ Coverage    72.78%   73.04%   +0.25%     
===========================================
  Files            9        9              
  Lines          779      779              
===========================================
+ Hits           567      569       +2     
+ Misses         212      210       -2     
Flag Coverage Δ
unittests 73.04% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keighrim keighrim merged commit 2782953 into develop Jul 1, 2024
5 checks passed
@keighrim keighrim deleted the 232-fix-rtparam-error branch July 1, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

clams app does not return "error views" when there's an error in runtime paramer
1 participant