Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clangd adds redundant parentheses when completing inside using-declaration #118

Closed
ilya-biryukov opened this issue Aug 7, 2019 · 1 comment
Closed

clangd adds redundant parentheses when completing inside using-declaration #118

ilya-biryukov opened this issue Aug 7, 2019 · 1 comment
Assignees
@ilya-biryukov
Labels
good first issue Good for newcomers

Comments

@ilya-biryukov
Copy link

ilya-biryukov commented Aug 7, 2019 •
edited 

namespace ns {
  void foo();
}

using ns::^

Expected: using ns::foo
Actual: using ns::foo()
@ilya-biryukov ilya-biryukov added the good first issue Good for newcomers label Aug 7, 2019
@ilya-biryukov ilya-biryukov self-assigned this Oct 24, 2019
@ilya-biryukov
Copy link
Author

Upcoming fix: https://reviews.llvm.org/D69382

arichardson pushed a commit to arichardson/llvm-project that referenced this issue Nov 16, 2019
@ilya-biryukov @arichardson
[clangd] Do not insert parentheses when completing a using declaration
a815070 
Summary:
Would be nice to also fix this in clang, but that looks like more work
if we want to preserve signatures in informative chunks.

Fixes clangd/clangd#118

Reviewers: kadircet

Reviewed By: kadircet

Subscribers: merge_guards_bot, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69382
shrouxm pushed a commit to sourcegraph/lsif-clang that referenced this issue Jul 12, 2020
@ilya-biryukov
[clangd] Do not insert parentheses when completing a using declaration
b68dab6 
Summary:
Would be nice to also fix this in clang, but that looks like more work
if we want to preserve signatures in informative chunks.

Fixes clangd/clangd#118

Reviewers: kadircet

Reviewed By: kadircet

Subscribers: merge_guards_bot, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69382
This was referenced Mar 4, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-biryukov ilya-biryukov

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilya-biryukov