Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include-cleaner: ParsedAST::getPragmaIncludes() only contains information for preamble. #1571

Closed
hokein opened this issue Apr 3, 2023 · 0 comments · Fixed by llvm/llvm-project#75612
Closed

include-cleaner: ParsedAST::getPragmaIncludes() only contains information for preamble. #1571

hokein opened this issue Apr 3, 2023 · 0 comments · Fixed by llvm/llvm-project#75612
Labels
include-cleaner

Comments

@hokein
Copy link
Contributor

hokein commented Apr 3, 2023

The PragmaInclude structure in clangd only contains the information for the preamble, this means the non-preamble IWYU pragmas are not respected in clangd, see the following example:

int abc;
// we still get an unused-include diagnostic.
#include "unused.h" // IWYU pragma: keep

One solution is to build a PragmaInclude when building the main AST and merge it with the one for preamble.
@hokein hokein mentioned this issue Dec 11, 2023
Closed
@kadircet kadircet mentioned this issue Dec 15, 2023
Merged
@hokein hokein mentioned this issue Jan 3, 2024
Closed
kadircet added a commit to llvm/llvm-project that referenced this issue Jan 3, 2024
@kadircet
[clangd] Track IWYU pragmas for non-preamble includes (#75612)
7837110 
This makes PragmaIncldues copyable, and copies it from preamble when
building a
new AST.

Fixes clangd/clangd#1843
Fixes clangd/clangd#1571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
include-cleaner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[clangd] Track IWYU pragmas for non-preamble includes kadircet/llvm-project
1 participant
@hokein