maybeDesugar in InlayHints doesn't desugar std::vector<int*>::reference
#1703
Assignees
Comments
Done |
|
Thanks :-D |
zyn0217
added a commit
to llvm/llvm-project
that referenced
this issue
Aug 1, 2023
This is a follow-up to D151785, addressing clangd/clangd#1703. The previous approach of peeling pointer types during a traversal using getPointeeType might have produced unexpected results; since the method would implicitly desugar the type if the type being passed in could not be cast to a Pointer-like Type. Reviewed By: nridge Differential Revision: https://reviews.llvm.org/D156300
doru1004
pushed a commit
to doru1004/llvm-project
that referenced
this issue
Aug 3, 2023
This is a follow-up to D151785, addressing clangd/clangd#1703. The previous approach of peeling pointer types during a traversal using getPointeeType might have produced unexpected results; since the method would implicitly desugar the type if the type being passed in could not be cast to a Pointer-like Type. Reviewed By: nridge Differential Revision: https://reviews.llvm.org/D156300
razmser
pushed a commit
to razmser/llvm-project
that referenced
this issue
Sep 8, 2023
This is a follow-up to D151785, addressing clangd/clangd#1703. The previous approach of peeling pointer types during a traversal using getPointeeType might have produced unexpected results; since the method would implicitly desugar the type if the type being passed in could not be cast to a Pointer-like Type. Reviewed By: nridge Differential Revision: https://reviews.llvm.org/D156300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the following code,
the hint for
xshould beint *&but we're still seeingvalue_typehere.(I should assign myself to this issue but I don't have access to it.)
The text was updated successfully, but these errors were encountered: