-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature help for function pointers with calling convention does not show parameter names #1729
Comments
(Edited title to clarify that the issue is with the content of the signature help popup. Inlay hints are a different feature.) |
Support for the case without a calling convention was added in #1068. |
Proposed fix: https://reviews.llvm.org/D157952 |
#define APIENTRY __stdcall
#define APIENTRYP APIENTRY *
#define GLAPI __attribute__ ((dllexport)) extern
#define GLAPI __declspec(dllexport) extern
#define GLAPI extern
// how it is defined by glad gl c generator
typedef void (APIENTRYP PFNGLNAMEDBUFFERSUBDATAPROC)(GLuint buffer, GLintptr offset, GLsizeiptr size, const void *data);
GLAPI PFNGLNAMEDBUFFERSUBDATAPROC glad_glNamedBufferSubData;
#define glNamedBufferSubData glad_glNamedBufferSubData
// this is made by me to clarify the issue
void glNamedBufferSubData_WRAP(GLuint buffer, GLintptr offset, GLsizeiptr size, const void *data){
glad_glNamedBufferSubData( buffer, offset, size, data);
}
void f(){
glNamedBufferSubData ( 0, sizeof(float[8]), sizeof(char)*1, (void*)(NULL));
glNamedBufferSubData_WRAP(0, sizeof(float[8]), sizeof(char)*1, (void*)(NULL));
} i also want to clarify desired result: |
Could you file a separate issue for this please? |
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
…g parameter names for signature help Fixes clangd/clangd#1729 Differential Revision: https://reviews.llvm.org/D157952
vscode / clangd 16.0.2 / win64 / clang
The text was updated successfully, but these errors were encountered: