Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show InlayHints for function pointers #1734

Closed
Befzz opened this issue Aug 17, 2023 · 1 comment
Closed

Show InlayHints for function pointers #1734

Befzz opened this issue Aug 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Befzz
Copy link

Befzz commented Aug 17, 2023

#define APIENTRY __stdcall
#define APIENTRYP APIENTRY *

#define GLAPI __attribute__ ((dllexport)) extern
#define GLAPI __declspec(dllexport) extern
#define GLAPI extern


// how it is defined by glad gl c generator
typedef void (APIENTRYP PFNGLNAMEDBUFFERSUBDATAPROC)(GLuint buffer, GLintptr offset, GLsizeiptr size, const void *data);
GLAPI PFNGLNAMEDBUFFERSUBDATAPROC glad_glNamedBufferSubData;
#define glNamedBufferSubData glad_glNamedBufferSubData

// this is made by me to clarify the issue
void glNamedBufferSubData_WRAP(GLuint buffer, GLintptr offset, GLsizeiptr size, const void *data){
  glad_glNamedBufferSubData( buffer,  offset,  size, data);
}
void f(){
  glNamedBufferSubData     (        0,        sizeof(float[8]),       sizeof(char)*1,      (void*)(NULL));
  glNamedBufferSubData_WRAP(0, sizeof(float[8]), sizeof(char)*1, (void*)(NULL));
}

image

desired result:
show inlay hints for function pointers
or make it optional (not sure about performance impact, usefulness etc.)

@Befzz Befzz added the enhancement New feature or request label Aug 17, 2023
@HighCommander4 HighCommander4 self-assigned this Aug 18, 2023
@HighCommander4
Copy link

Proposed fix: https://reviews.llvm.org/D158249

razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 2, 2023
razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 2, 2023
razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 2, 2023
razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 3, 2023
razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 3, 2023
razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 6, 2023
razmser pushed a commit to SuduIDE/llvm-project that referenced this issue Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants