Show access specifiers as part of the Hover information #382
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
|
this sounds a useful feature to me. And sometimes I'd like to know whether a member function is overriding a virtual member from a base class, would be nice to show it in hover as well. |
sam-mccall
added
good first issue
kadircet
pushed a commit
to llvm/llvm-project
that referenced
this issue
May 27, 2020
Summary: For clangd/clangd#382 This commit adds access specifier information to the hover contents. For example, the hover information of a class field or member function will now indicate if the field or member is private, public, or protected. This can be particularly useful when a developer is in the implementation file and wants to know if a particular member definition is public or private. Reviewers: kadircet Reviewed By: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D80472
|
Looks like this is implemented now. |
|
Yes, I implemented this in llvm/llvm-project@6407aa9 I'll close the issue. |
arichardson
pushed a commit
to arichardson/llvm-project
that referenced
this issue
Jul 3, 2020
Summary: For clangd/clangd#382 This commit adds access specifier information to the hover contents. For example, the hover information of a class field or member function will now indicate if the field or member is private, public, or protected. This can be particularly useful when a developer is in the implementation file and wants to know if a particular member definition is public or private. Reviewers: kadircet Reviewed By: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D80472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One piece of information about a method definition that it's sometimes needed is if its member access is public, private, etc. This can be useful, for example, if you are inside a
.cppfile and want to know quickly if a member is accessible outside of the class or not. Knowing if a field is protected can also be useful if we consider them a code smell and would like to refactor them.I propose this can be shown as part of the hover Markdown contents. For example, instead of
Clangd would show
Any thoughts? As far as I know, visibility, linkage, member access is not trivially computable in Clang, but maybe if you restrict it to a couple of easy and useful cases (like member method accessibility), the feature can be reliable and useful to programmers, without much impact on the information that is already available in the hover popup. Thanks.
The text was updated successfully, but these errors were encountered: