Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick: 294b9d43cae77ea15453ec82203368903db4f538 #422

Closed
kadircet opened this issue Jun 10, 2020 · 0 comments
Closed

Cherrypick: 294b9d43cae77ea15453ec82203368903db4f538 #422

kadircet opened this issue Jun 10, 2020 · 0 comments
Assignees
@sam-mccall
Labels
cherrypick Consider backport to release branch

Comments

@kadircet
Copy link
Member

Commit:

Why is this important or safe?
Disables all output generating compiler flags. They are not useful for clangd, as we don't want to have side effects, especially on file system. Also these might even lead to LSP violations as some of the output is put to stderr/stdout.
@kadircet kadircet added the cherrypick Consider backport to release branch label Jun 10, 2020
@sam-mccall sam-mccall self-assigned this Jun 10, 2020
sam-mccall pushed a commit to llvm/llvm-project that referenced this issue Jun 10, 2020
@kadircet @sam-mccall
[clangd] Disable all dependency outputs
52f2d6d 
Summary: Fixes clangd/clangd#322

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78833

(cherry picked from commit 294b9d4)

Fixes clangd/clangd#422
ajohnson-uoregon pushed a commit to ajohnson-uoregon/clang-rewrite-only that referenced this issue Jul 17, 2022
@kadircet @sam-mccall
[clangd] Disable all dependency outputs
6bf72b6 
Summary: Fixes clangd/clangd#322

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78833

(cherry picked from commit 5bc7cc0)

Fixes clangd/clangd#422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-mccall sam-mccall

Labels
cherrypick Consider backport to release branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sam-mccall @kadircet