-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support partially qualified names in workspace/symbol #550
Comments
That definitely makes sense to me, send out https://reviews.llvm.org/D88814. This might degrade the search performance for top-level but not fully-qualified searches. e.g. I wonder what will others think tho. Hence did not assign anyone for review yet :D |
To summarize an offline discussion and give a bit more details:
|
This will enable queries like "clangd::" to find symbols under clangd namespace, without requiring full "clang::clangd::" qualification. Since Fuzzyfind performs the search under all scopes and only boosts the symbols from relevant namespaces, we might get symbols from non-matching namespaces. This patch chooses to drop those as they clearly do not match the query. Fixes clangd/clangd#550. Differential Revision: https://reviews.llvm.org/D88814
This will enable queries like "clangd::" to find symbols under clangd namespace, without requiring full "clang::clangd::" qualification. Since Fuzzyfind performs the search under all scopes and only boosts the symbols from relevant namespaces, we might get symbols from non-matching namespaces. This patch chooses to drop those as they clearly do not match the query. Fixes clangd/clangd#550. Differential Revision: https://reviews.llvm.org/D88814
I originally filed this as clangd/vscode-clangd#31 (it was transferred into the vscode-clangd repo after filing). That ticket has been closed, but the issue is only partially fixed.
Specifically, in that ticket, a vscode-specific issue that led to
workspace/symbol
queries with a fully qualified name as a search string not returning results, was fixed.There is a remaining issue on the server side, that
workspace/symbol
queries with partially qualified names do not return results. For example, searching forClass::Method
should matchns::Class::Method
orns1::ns2::Class::Method
if such entities exist.The text was updated successfully, but these errors were encountered: