Use VSCode's native inlay-hints support, now it's available. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the PR for native support inlay hints just merged, commit, and released in vscode (latest stable version), so we can try to fast-track this PR. Thanks for the work @sam-mccall |
|
This should be good to go now. |
hokein
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ready to go yet:
vpx vscode-dts main).Nevertheless it does work in latest insiders. VSCode seems to request hints for the whole doc, but then continues to issue requests as you scroll around. It makes me a bit sad that scrolling will now eat CPU!
cc @HighCommander4