Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspaceSymbols work on qualified name. #32

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

hokein
Copy link
Collaborator

@hokein hokein commented May 18, 2020

Fixes #31

Tested on LLVM project, verified with qualified names and unqualified names.

@hokein hokein requested a review from sam-mccall May 18, 2020 09:37
@kadircet
Copy link
Member

just a drive by comment. i remember this was working in vscode last time i checked (which was a looong time ago). so are we sure this is not a regression on their side (not saying we shouldn't fix it in our extension, but maybe we should also file a bug to them) ?

@hokein
Copy link
Collaborator Author

hokein commented May 18, 2020

just a drive by comment. i remember this was working in vscode last time i checked (which was a looong time ago). so are we sure this is not a regression on their side (not saying we shouldn't fix it in our extension, but maybe we should also file a bug to them) ?

Not sure this is a regression, personally I didn't often use this feature in VSCode as it didn't give quite useful results (maybe because of this bug?).

The closest issue I found is microsoft/vscode#23509, it looks like they suggest to address it in the extension side.

@sam-mccall
Copy link
Member

I filed microsoft/vscode#98125 asking for a real fix in VSCode, but this workaround seems fine, we should do it only in the cases necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support qualified names in workspace/symbol
3 participants