Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.1.25 #516

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

HighCommander4
Copy link
Contributor

No description provided.

@HighCommander4
Copy link
Contributor Author

(Marking as WIP since we should probably include #515 in the release)

@xidianzhangjun
Copy link

When will v0.1.25 be released?

@HighCommander4
Copy link
Contributor Author

When will v0.1.25 be released?

I finally got to reviewing #515, apologies for the delay. Once #515 merges, I will resubmit this for review.

@HighCommander4 HighCommander4 marked this pull request as ready for review September 10, 2023 06:36
@HighCommander4
Copy link
Contributor Author

Once #515 merges, I will resubmit this for review.

#515 has now merged, and I've resubmitted this for review.

@xidianzhangjun
Copy link

What's new in this version and when will it be released? 💯 : )

@HighCommander4
Copy link
Contributor Author

What's new in this version

You can see what's new since the last release in the changelog entry which this PR completes.

I'd say the most notable change is #193.

and when will it be released? 💯 : )

It will be released when this PR is merged and the command to publish the new release to the VSCode extension marketplace is run.

@sam-mccall @hokein ^ I would appreciate a review on this

@simon8233
Copy link

Sorry , may I know where I can download latest 0.1.25 to testing?

@HighCommander4
Copy link
Contributor Author

HighCommander4 commented Oct 24, 2023

Sorry , may I know where I can download latest 0.1.25 to testing?

We don't currently have anything in the way of snapshot releases (#517 is on file about that), so the current way would be to build the extension from source.

Instructions for that can be found at https://github.com/clangd/vscode-clangd/blob/master/DEVELOPING.md. The extension can be packaged into a .vsix file using npm run package.

@xidianzhangjun
Copy link

Sorry , may I know where I can download latest 0.1.25 to testing?

We don't currently have anything in the way of snapshot releases (#517 is on file about that), so the current way would be to build the extension from source.

Instructions for that can be found at https://github.com/clangd/vscode-clangd/blob/master/DEVELOPING.md. The extension can be packaged into a .vsix file using npm run package.

The review seems to be pended. :-;

@HighCommander4
Copy link
Contributor Author

HighCommander4 commented Nov 17, 2023

@kadircet perhaps you could help out with getting this new release out? I think users are eager to try out the new inactive regions presentation implemented in #193 (and I'm eager to get user feedback about it and start thinking about next steps such as proposing the protocol for addition to LSP).

@HighCommander4
Copy link
Contributor Author

I'm going to go ahead and merge this patch without review; I hope that's fine, since the contents of the patch itself are just an update to the changelog and version metadata and so shouldn't be controversial in any way.

However, I don't have the permission to publish the new version to the VSCode Marketplace -- @sam-mccall @kadircet @hokein could one of you please do that?

@HighCommander4 HighCommander4 merged commit 71338a5 into clangd:master Nov 29, 2023
1 check passed
@HighCommander4
Copy link
Contributor Author

However, I don't have the permission to publish the new version to the VSCode Marketplace -- @sam-mccall @kadircet @hokein could one of you please do that?

It appears I was mistaken about there being a manual publication step, since 0.1.25 automatically appeared on the marketplace.

(I do now see that there is a Github Action that runs npm run publish when package.json changes.)

jnooree added a commit to jnooree/noctis that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants