Added suppressCompletionReranking configuration setting. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e forced clangd-based completion ranking.
|
I'm really sorry we let this fly by. I think it makes sense and we should merge it, just want to tweak the wording a little to ensure it's clear. |
sam-mccall
requested changes
Nov 20, 2020
package.json
Outdated
| @@ -119,6 +119,11 @@ | |||
| }, | |||
| "description": "Extra clang flags used to parse files when no compilation database is found." | |||
| }, | |||
| "clangd.suppressCompletionReranking": { | |||
There was a problem hiding this comment.
I think the doulbe-negative feel (suppress + "reranking" implying undoing the old ranking) makes this a bit hard to understand. And the description only mentions one half of the tradeoff, so it's hard to make a choice.
What about clangd.serverCompletionRanking / "Always rank completion items on the server as you type. This produces more accurate results at the cost of higher latency than client-side filtering."
There was a problem hiding this comment.
Thanks, I did not like the original name as well =) Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added suppressCompletionReranking configuration setting to disable the forced clangd-based completion ranking added in https://github.com/OlegOAndreev/vscode-clangd/commit/5616b189db01094940a70db2e8314d9135ab9a10#diff-45327f86d4438556066de133327f4ca2
Motivation: for shorter completion lists (e.g. object methods after the dot/arrow) the forced round-trips to clangd add some perceptible UI lag (fixes #62, but may as well fix #37).