Merge pull request #60 from clanhr/allow-self-approver-on-expenses

Allow self-approver to approve pending expenses

project.clj

@@ -1,4 +1,4 @@
-(defproject clanhr/auth "1.31.0"
+(defproject clanhr/auth "1.32.0"
   :description "ClanHR's Auth Library"
   :url "https://github.com/clanhr/auth"
   :license {:name "The MIT License"

src/clanhr/auth/authorization_rules.clj

@@ -18,6 +18,7 @@
    :administrator-member ["admin" "hrmanager"]})
 
 (def ^:const approver "approver")
+(def ^:const self-approver "self-approver")
 (def ^:const expenses-manager "expensesManager")
 (def ^:const absences-manager "absencesManager")
 
@@ -35,7 +36,7 @@
    :can-mark-account-as-paid (:developer-member profile)
    :change-absence-state (conj (:board-member profile) approver absences-manager)
    :change-expense-state (conj (:board-member profile) approver expenses-manager)
-   :can-auto-approve-expenses (conj (:board-member profile) approver expenses-manager)
+   :can-auto-approve-expenses (conj (:board-member profile) approver self-approver expenses-manager)
    :settings-access (conj (:board-member profile) absences-manager expenses-manager)
    :can-see-full-user-info (:board-member profile)
    :delete-user (:board-member profile)

test/clanhr/auth/authorization_rules_test.clj

@@ -28,6 +28,8 @@
           (authorization-rules/run :change-expense-state ["expensesManager"])))
     (is (result/succeeded?
           (authorization-rules/run :can-auto-approve-expenses ["expensesManager"])))
+    (is (result/succeeded?
+          (authorization-rules/run :can-auto-approve-expenses ["self-approver"])))
     (is (result/succeeded?
           (authorization-rules/run :reports-access ["absencesManager"])))
     (is (result/succeeded?